Ticket #2218: 2218_3.patch

_whatsnew.html

@@ -116 +116 @@
                         changed from "&lt;?=" to "&lt;? echo".</li> 
                 <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/2254">#2254</a>] Minor fix in fckselection for
                         nodeName attribute detection.</li> 
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/2218">#2218</a>] Improved Gecko based browser
+                        detection to accept Epiphany/Gecko as well.</li>
         </ul>
         <h3>
                 Version 2.6</h3>

editor/_source/internals/fckbrowserinfo.js

@@ -28 +28 @@
         IsIE            : /*@cc_on!@*/false,
         IsIE7           : /*@cc_on!@*/false && ( parseInt( s.match( /msie (\d+)/ )[1], 10 ) >= 7 ),
         IsIE6           : /*@cc_on!@*/false && ( parseInt( s.match( /msie (\d+)/ )[1], 10 ) >= 6 ),
-        IsGecko         : s.Contains('gecko/'),
+        IsGecko         : navigator.product == 'Gecko',
         IsSafari        : s.Contains(' applewebkit/'),          // Read "IsWebKit"
         IsOpera         : !!window.opera,
         IsAIR           : s.Contains(' adobeair/'),
@@ -38 +38 @@
 // Completes the browser info with further Gecko information.
 (function( browserInfo )
 {
+        browserInfo.IsGecko = browserInfo.IsGecko && !browserInfo.IsSafari && !browserInfo.IsOpera ;
         browserInfo.IsGeckoLike = ( browserInfo.IsGecko || browserInfo.IsSafari || browserInfo.IsOpera ) ;
 
         if ( browserInfo.IsGecko )
         {
-                var geckoVersion = s.match( /gecko\/(\d+)/ )[1] ;
+                var geckoMatch = s.match( /rv:(\d+\.\d+)/ ) ;
+                var geckoVersion = geckoMatch && parseFloat( geckoMatch[1] ) ;
 
                 // Actually "10" refers to Gecko versions before Firefox 1.5, when
                 // Gecko 1.8 (build 20051111) has been released.
@@ -51 +53 @@
                 // than 20051111, so we must also check for the revision number not to
                 // be 1.7 (we are assuming that rv < 1.7 will not have build > 20051111).
 
-                // TODO: Future versions may consider the rv number only, but it is
-                // still to check that all Gecko based browser present the rv number.
-                browserInfo.IsGecko10 = ( ( geckoVersion < 20051111 ) || ( /rv:1\.7/.test(s) ) ) ;
-                browserInfo.IsGecko19 = /rv:1\.9/.test(s) ;
+                if ( geckoVersion )
+                {
+                        browserInfo.IsGecko10 = ( geckoVersion < 1.8 ) ;
+                        browserInfo.IsGecko19 = ( geckoVersion > 1.8 ) ;
+                }
         }
-        else
-                browserInfo.IsGecko10 = false ;
 })(FCKBrowserInfo) ;