Ticket #2263: 2263.patch

_whatsnew.html

@@ -42 +42 @@
         <p>
                 Fixed Bugs:</p>
         <ul>
-                <li></li>
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/2263">#2263</a>] Fixed a JavaScript
+                        error in IE which occurs when there are placeholder elements in the document and the user
+                        has pressed the Source button.</li>
         </ul>
         <p>
                 <a href="_whatsnew_history.html">See previous versions history</a></p>

editor/_source/internals/fck.js

@@ -631 +631 @@
 
                 var sHtml ;
 
-                // Update the HTML in the view output to show.
+                // Update the HTML in the view output to show, also update
+                // FCKTempBin for IE to avoid #2263.
                 if ( bIsWysiwyg )
                 {
                         FCKCommands.GetCommand( 'ShowBlocks' ).SaveState() ;
@@ -640 +641 @@
 
                         sHtml = FCK.GetXHTML( FCKConfig.FormatSource ) ;
 
+                        if ( FCKBrowserInfo.IsIE )
+                                FCKTempBin.ToHtml() ;
+
                         if ( sHtml == null )
                                 return false ;
                 }
@@ -937 +941 @@
         FCK.EditorWindow        = FCK.EditingArea.Window ;
         FCK.EditorDocument      = FCK.EditingArea.Document ;
 
+        if ( FCKBrowserInfo.IsIE )
+                FCKTempBin.ToElements() ;
+
         FCK.InitializeBehaviors() ;
 
         // Listen for mousedown and mouseup events for tracking drag and drops.
@@ -1089 +1096 @@
                 while ( i < this.Elements.length )
                         this.Elements[ i++ ] = null ;
                 this.Elements.length = 0 ;
+        },
+
+        ToHtml : function()
+        {
+                for ( var i = 0 ; i < this.Elements.length ; i++ )
+                        this.Elements[i] = this.Elements[i].outerHTML ;
+        },
+
+        ToElements : function()
+        {
+                var node = FCK.EditorDocument.createElement( 'div' ) ;
+                for ( var i = 0 ; i < this.Elements.length ; i++ )
+                {
+                        if ( typeof( this.Elements[i] ) == 'string' )
+                        {
+                                node.innerHTML = this.Elements[i] ;
+                                this.Elements[i] = node.firstChild ;
+                        }
+                }
         }
 } ;
 

editor/dialog/fck_anchor.html

@@ -121 +121 @@
         if ( aNewAnchors.length == 0 )
         {
                 // Nothing was selected, so now just create a normal A
-                aNewAnchors.push( oEditor.FCK.InsertElement( 'a' ) ) ;
+                if ( FCKBrowserInfo.IsIE )
+                        aNewAnchors.push( oEditor.FCK.InsertElement( '<a name="' + FCKTools.HTMLEncode( sNewName ).replace( '"', '&quot;' ) + '">' ) ) ;
+                else
+                {
+                        var n ;
+                        aNewAnchors.push( ( n = oEditor.FCK.InsertElement( 'a' ), n.name = sNewName, n ) ) ;
+                }
         }
         else
         {
@@ -135 +141 @@
         {
                 oAnchor = aNewAnchors[i] ;
 
-                // Set the name
-                oAnchor.name = sNewName ;
-
                 // IE does require special processing to show the Anchor's image
                 // Opera doesn't allow to select empty anchors
                 if ( FCKBrowserInfo.IsIE || FCKBrowserInfo.IsOpera )