Ticket #2296: 2296_2.patch

_whatsnew.html

@@ -64 +64 @@
                 <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/2149">#2149</a>] CSS urls
                         with querystring parameters were not being accepted for CSS values in the configuration
                         file (like EditorAreaCSS).</li>
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/2296">#2296</a>] Fixed permission denied error
+                        on clicking on files in the file browser.</li>
         </ul>
         <p>
         </p>

editor/filemanager/browser/default/browser.html

@@ -43 +43 @@
                         break ;
                 }
                 catch( e )
-                {
-                        break ;
-                }
+                {}
 
                 // Remove a domain part: www.mytest.example.com => mytest.example.com => example.com ...
                 d = d.replace( /.*?(?:\.|$)/, '' ) ;

editor/filemanager/browser/default/frmactualfolder.html

@@ -41 +41 @@
                         break ;
                 }
                 catch( e )
-                {
-                        break ;
-                }
+                {}
 
                 // Remove a domain part: www.mytest.example.com => mytest.example.com => example.com ...
                 d = d.replace( /.*?(?:\.|$)/, '' ) ;

editor/filemanager/browser/default/js/common.js

@@ -36 +36 @@
                         break ;
                 }
                 catch( e )
-                {
-                        break ;
-                }
+                {}
 
                 // Remove a domain part: www.mytest.example.com => mytest.example.com => example.com ...
                 d = d.replace( /.*?(?:\.|$)/, '' ) ;

editor/filemanager/browser/default/js/fckxml.js

@@ -61 +61 @@
                 {
                         if ( oXmlHttp.readyState == 4 )
                         {
-                                if ( ( oXmlHttp.status != 200 && oXmlHttp.status != 304 ) || oXmlHttp.responseXML == null || oXmlHttp.responseXML.firstChild == null )
+                                var oXml ;
+                                try
                                 {
+                                        // this is the same test for an FF2 bug as in fckxml_gecko.js
+                                        // but we've moved the responseXML assignment into the try{}
+                                        // so we don't even have to check the return status codes.
+                                        var test = oXmlHttp.responseXML.firstChild ;
+                                        oXml = oXmlHttp.responseXML ;
+                                }
+                                catch ( e )
+                                {
+                                        try
+                                        {
+                                                oXml = (new DOMParser()).parseFromString( oXmlHttp.responseText, 'text/xml' ) ;
+                                        }
+                                        catch ( e ) {}
+                                }
+
+                                if ( !oXml || !oXml.firstChild || oXml.firstChild.nodeName == 'parsererror' )
+                                {
                                         alert( 'The server didn\'t send back a proper XML response. Please contact your system administrator.\n\n' +
                                                         'XML request error: ' + oXmlHttp.statusText + ' (' + oXmlHttp.status + ')\n\n' +
                                                         'Requested URL:\n' + urlToCall + '\n\n' +
@@ -70 +88 @@
                                         return ;
                                 }
 
-                                oFCKXml.DOMDocument = oXmlHttp.responseXML ;
+                                oFCKXml.DOMDocument = oXml ;
                                 asyncFunctionPointer( oFCKXml ) ;
                         }
                 }