Ticket #439: 439.2.patch

_whatsnew.html

@@ -37 +37 @@
         <p>
                 New Features and Improvements:</p>
         <ul>
-                <li></li>
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/439">#439</a>] Added a new
+                        right-click menu open for opening links in the editor.</li>
         </ul>
         <p>
                 Fixed Bugs:</p>

editor/_source/commandclasses/fck_othercommands.js

@@ -300 +300 @@
         var state = FCK.GetNamedCommandState( this.Name ) ;
 
         // Check that it isn't an anchor
-        if ( state == FCK_TRISTATE_OFF && FCK.EditMode == FCK_EDITMODE_WYSIWYG )
+        if ( state == FCK_TRISTATE_OFF )
         {
                 var oLink = FCKSelection.MoveToAncestorNode( 'A' ) ;
                 var bIsAnchor = ( oLink && oLink.name.length > 0 && oLink.href.length == 0 ) ;
@@ -311 +311 @@
         return state ;
 }
 
+FCKVisitLinkCommand = function()
+{
+        this.Name = 'VisitLink';
+}
+FCKVisitLinkCommand.prototype =
+{
+        GetState : function()
+        {
+                if ( FCK.EditMode != FCK_EDITMODE_WYSIWYG )
+                        return FCK_TRISTATE_DISABLED ;
+                var state = FCK.GetNamedCommandState( 'Unlink' ) ;
+
+                if ( state == FCK_TRISTATE_OFF )
+                {
+                        var el = FCKSelection.MoveToAncestorNode( 'A' ) ;
+                        if ( !el.href )
+                                state = FCK_TRISTATE_DISABLED ;
+                }
+
+                return state ;
+        },
+
+        Execute : function()
+        {
+                var el = FCKSelection.MoveToAncestorNode( 'A' ) ;
+                var url = el.getAttribute( '_fcksavedurl' ) ;
+
+                // Check if it's a full URL, a full URL includes the scheme name, see RFC3986.
+                // If not full URL, we'll need to apply the BaseHref setting.
+                if ( ! /^[A-Za-z][0-9A-Za-z+-.]*:/.test( url ) )
+                {
+                        var baseHref = FCKConfig.BaseHref ;
+                        var parentWindow = FCK.GetInstanceObject( 'parent' ) ;
+                        if ( !baseHref )
+                        {
+                                baseHref = parentWindow.document.location.href ;
+                                baseHref = baseHref.substring( 0, baseHref.lastIndexOf( '/' ) + 1 ) ;
+                        }
+
+                        if ( /^\//.test( url ) )
+                        {
+                                try
+                                {
+                                        baseHref = baseHref.match( /^([A-Za-z][0-9A-Za-z+-.]*:[\/]+[^\/]+)/ )[1] ;
+                                }
+                                catch ( e )
+                                {
+                                        baseHref = parentWindow.document.location.protocol + '://' + parentWindow.parent.document.location.host ;
+                                }
+                        }
+
+                        url = baseHref + url ;
+                }
+
+                if ( !window.open( url, 'FCKVisitLink' ) )
+                        alert( FCKLang.VisitLinkBlocked ) ;
+        }
+} ;
+
 // FCKSelectAllCommand
 var FCKSelectAllCommand = function()
 {

editor/_source/internals/fck_contextmenu.js

@@ -131 +131 @@
                                         if ( bInsideLink )
                                                 menu.AddItem( 'Link', FCKLang.EditLink          , 34 ) ;
                                         menu.AddItem( 'Unlink'  , FCKLang.RemoveLink    , 35 ) ;
+                                        menu.AddSeparator() ;
+                                        menu.AddItem( 'VisitLink', FCKLang.VisitLink, 34 ) ;
                                 }
                         }} ;
 

editor/_source/internals/fckcommands.js

@@ -51 +51 @@
                 case 'Templates'        : oCommand = new FCKDialogCommand( 'Templates'  , FCKLang.DlgTemplatesTitle             , 'dialog/fck_template.html'    , 380, 450 ) ; break ;
                 case 'Link'                     : oCommand = new FCKDialogCommand( 'Link'               , FCKLang.DlgLnkWindowTitle             , 'dialog/fck_link.html'                , 400, 300 ) ; break ;
                 case 'Unlink'           : oCommand = new FCKUnlinkCommand() ; break ;
+                case 'VisitLink'        : oCommand = new FCKVisitLinkCommand() ; break ;
                 case 'Anchor'           : oCommand = new FCKDialogCommand( 'Anchor'             , FCKLang.DlgAnchorTitle                , 'dialog/fck_anchor.html'              , 370, 160 ) ; break ;
                 case 'AnchorDelete'     : oCommand = new FCKAnchorDeleteCommand() ; break ;
                 case 'BulletedList'     : oCommand = new FCKDialogCommand( 'BulletedList', FCKLang.BulletedListProp             , 'dialog/fck_listprop.html?UL' , 370, 160 ) ; break ;

editor/lang/en-au.js

@@ -44 +44 @@
 InsertLinkLbl           : "Link",
 InsertLink                      : "Insert/Edit Link",
 RemoveLink                      : "Remove Link",
+VisitLink                       : "Open Link",
 Anchor                          : "Insert/Edit Anchor",
 AnchorDelete            : "Remove Anchor",
 InsertImageLbl          : "Image",
@@ -157 +158 @@
 NoActiveX                       : "Your browser's security settings could limit some features of the editor. You must enable the option \"Run ActiveX controls and plug-ins\". You may experience errors and notice missing features.",
 BrowseServerBlocked : "The resources browser could not be opened. Make sure that all popup blockers are disabled.",
 DialogBlocked           : "It was not possible to open the dialog window. Make sure all popup blockers are disabled.",
+VisitLinkBlocked        : "It was not possible to open a new window. Make sure all popup blockers are disabled.",
 
 // Dialogs
 DlgBtnOK                        : "OK",

editor/lang/en-ca.js

@@ -44 +44 @@
 InsertLinkLbl           : "Link",
 InsertLink                      : "Insert/Edit Link",
 RemoveLink                      : "Remove Link",
+VisitLink                       : "Open Link",
 Anchor                          : "Insert/Edit Anchor",
 AnchorDelete            : "Remove Anchor",
 InsertImageLbl          : "Image",
@@ -157 +158 @@
 NoActiveX                       : "Your browser's security settings could limit some features of the editor. You must enable the option \"Run ActiveX controls and plug-ins\". You may experience errors and notice missing features.",
 BrowseServerBlocked : "The resources browser could not be opened. Make sure that all popup blockers are disabled.",
 DialogBlocked           : "It was not possible to open the dialog window. Make sure all popup blockers are disabled.",
+VisitLinkBlocked        : "It was not possible to open a new window. Make sure all popup blockers are disabled.",
 
 // Dialogs
 DlgBtnOK                        : "OK",

editor/lang/en-uk.js

@@ -44 +44 @@
 InsertLinkLbl           : "Link",
 InsertLink                      : "Insert/Edit Link",
 RemoveLink                      : "Remove Link",
+VisitLink                       : "Open Link",
 Anchor                          : "Insert/Edit Anchor",
 AnchorDelete            : "Remove Anchor",
 InsertImageLbl          : "Image",
@@ -157 +158 @@
 NoActiveX                       : "Your browser's security settings could limit some features of the editor. You must enable the option \"Run ActiveX controls and plug-ins\". You may experience errors and notice missing features.",
 BrowseServerBlocked : "The resources browser could not be opened. Make sure that all popup blockers are disabled.",
 DialogBlocked           : "It was not possible to open the dialog window. Make sure all popup blockers are disabled.",
+VisitLinkBlocked        : "It was not possible to open a new window. Make sure all popup blockers are disabled.",
 
 // Dialogs
 DlgBtnOK                        : "OK",

editor/lang/en.js

@@ -44 +44 @@
 InsertLinkLbl           : "Link",
 InsertLink                      : "Insert/Edit Link",
 RemoveLink                      : "Remove Link",
+VisitLink                       : "Open Link",
 Anchor                          : "Insert/Edit Anchor",
 AnchorDelete            : "Remove Anchor",
 InsertImageLbl          : "Image",
@@ -157 +158 @@
 NoActiveX                       : "Your browser's security settings could limit some features of the editor. You must enable the option \"Run ActiveX controls and plug-ins\". You may experience errors and notice missing features.",
 BrowseServerBlocked : "The resources browser could not be opened. Make sure that all popup blockers are disabled.",
 DialogBlocked           : "It was not possible to open the dialog window. Make sure all popup blockers are disabled.",
+VisitLinkBlocked        : "It was not possible to open a new window. Make sure all popup blockers are disabled.",
 
 // Dialogs
 DlgBtnOK                        : "OK",

editor/lang/zh-cn.js

@@ -44 +44 @@
 InsertLinkLbl           : "超链接",
 InsertLink                      : "插入/编辑超链接",
 RemoveLink                      : "取消超链接",
+VisitLink                       : "打开超链接",
 Anchor                          : "插入/编辑锚点链接",
 AnchorDelete            : "清除锚点链接",
 InsertImageLbl          : "图象",
@@ -157 +158 @@
 NoActiveX                       : "浏览器安全设置限制了本编辑器的某些功能。您必须启用安全设置中的“运行 ActiveX 控件和插件”，否则将出现某些错误并缺少功能。",
 BrowseServerBlocked : "无法打开资源浏览器，请确认是否启用了禁止弹出窗口。",
 DialogBlocked           : "无法打开对话框窗口，请确认是否启用了禁止弹出窗口或网页对话框（IE）。",
+VisitLinkBlocked        : "无法打开新窗口，请确认是否启用了禁止弹出窗口或网页对话框（IE）。",
 
 // Dialogs
 DlgBtnOK                        : "确定",

editor/lang/zh.js

@@ -44 +44 @@
 InsertLinkLbl           : "超連結",
 InsertLink                      : "插入/編輯超連結",
 RemoveLink                      : "移除超連結",
+VisitLink                       : "開啟超連結",
 Anchor                          : "插入/編輯錨點",
 AnchorDelete            : "移除錨點",
 InsertImageLbl          : "影像",
@@ -157 +158 @@
 NoActiveX                       : "瀏覽器的安全性設定限制了本編輯器的某些功能。您必須啟用安全性設定中的「執行ActiveX控制項與外掛程式」項目，否則本編輯器將會出現錯誤並缺少某些功能",
 BrowseServerBlocked : "無法開啟資源瀏覽器，請確定所有快顯視窗封鎖程式是否關閉",
 DialogBlocked           : "無法開啟對話視窗，請確定所有快顯視窗封鎖程式是否關閉",
+VisitLinkBlocked        : "無法開啟新視窗，請確定所有快顯視窗封鎖程式是否關閉",
 
 // Dialogs
 DlgBtnOK                        : "確定",