Ticket #738: 738.patch

_whatsnew.html

@@ -75 +75 @@
                         are now properly sized in Opera.</li>
                 <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/1782">#1782</a>] Clicking on radio
                         buttons or checkboxes in the editor in IE will no longer cause lockups in IE.</li>
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/738">#738</a>] Button type can now
+                        be changed after creation.</li>
         </ul>
         <p>
                 <a href="_whatsnew_history.html">See previous versions history</a>

editor/dialog/fck_button.html

@@ -47 +47 @@
                 GetE('txtName').value   = oActiveEl.name ;
                 GetE('txtValue').value  = oActiveEl.value ;
                 GetE('txtType').value   = oActiveEl.type ;
-
-                GetE('txtType').disabled = true ;
         }
         else
                 oActiveEl = null ;
@@ -68 +66 @@
                 oActiveEl.type = GetE('txtType').value ;
                 oActiveEl = oEditor.FCK.InsertElement( oActiveEl ) ;
         }
+        else if ( oActiveEl && oActiveEl.type != GetE( 'txtType' ).value )
+        {
+                var oNewEl = oEditor.FCK.EditorDocument.createElement( 'INPUT' ) ;
+                oNewEl.type = GetE( 'txtType' ).value ;
+                oActiveEl = oEditor.FCK.InsertElement( oNewEl ) ;
 
+                // FCKDialog.SelectionData is broken by now since we've deleted the previously selected element.
+                // So we need to reassign it.
+                if ( oEditor.FCKBrowserInfo.IsIE && oEditor.FCKDialog.SelectionData )
+                {
+                        var range = oEditor.FCK.EditorDocument.body.createControlRange() ;
+                        range.add( oActiveEl ) ;
+                        oEditor.FCKDialog.SelectionData = range ;
+                }
+        }
+
         oActiveEl.name = GetE('txtName').value ;
         SetAttribute( oActiveEl, 'value', GetE('txtValue').value ) ;