Changeset 1026 for FCKeditor/branches/versions/2.5.x/editor/_source/internals/fckxhtml.js

Timestamp:

2007-10-16 04:36:44 (2 years ago)

Author:

martinkou

Message:

Fixed #1414 : Fixed the issue where entity codes inside <pre> blocks are incorrectly unescaped when switching to Source mode.

Files:

• FCKeditor/branches/versions/2.5.x/editor/_source/internals/fckxhtml.js (modified) (1 diff)

FCKeditor/branches/versions/2.5.x/editor/_source/internals/fckxhtml.js

@@ -383 +383 @@
                         var val = item.nodeValue ;
                         if ( item.nodeType == 3 && i == 0 )
-                                node.appendChild( FCKXHtml.XML.createTextNode( FCKXHtml._AppendSpecialItem( '\r\n' + val ) ) ) ;
+                        {
+                                // We shouldn't put the plain text value of the text node directly into HTML. (See #1414)
+                                var dummyNode = document.createElement( 'pre' ) ;
+                                dummyNode.appendChild( document.createTextNode( val ) ) ;
+                                node.appendChild( FCKXHtml.XML.createTextNode( FCKXHtml._AppendSpecialItem( '\r\n' + dummyNode.innerHTML ) ) ) ;
+                        }
                         else
                                 FCKXHtml._AppendNode( node, item ) ;