Changeset 1089

Timestamp:

2007-11-19 08:59:39 (9 months ago)

Author:

martinkou

Message:

Fixed #1514 : Fixed the issue where floating panels are positioned incorrectly when FCKeditor is not static positioned.

Location:

FCKeditor/trunk/editor/_source

Files:

• classes/fckpanel.js (modified) (2 diffs)
• internals/fckdomtools.js (modified) (1 diff)

FCKeditor/trunk/editor/_source/classes/fckpanel.js

@@ -191 +191 @@
                 iMainWidth = eMainNode.offsetWidth || eMainNode.firstChild.offsetWidth ;
 
+                // Base the popup coordinates upon the coordinates of relElement.
                 var oPos = FCKTools.GetElementPosition(
                         relElement.nodeType == 9 ?
@@ -197 +198 @@
                         this._Window ) ;
 
+                // Minus the offsets provided by any positioned parent element of the panel iframe.
+                var positionedAncestor = FCKDomTools.GetPositionedAncestor( FCKTools.GetElementWindow( this._IFrame ), this._IFrame.parentNode ) ;
+                if ( positionedAncestor )
+                {
+                        // GetElementPosition() does not work here for some reason... so I'm using GetDocumentPosition() here instead.
+                        var nPos = FCKTools.GetDocumentPosition( FCKTools.GetElementWindow( positionedAncestor ), positionedAncestor ) ;
+                        oPos.X -= nPos.x ;
+                        oPos.Y -= nPos.y ;
+                }
+
                 if ( this.IsRTL && !this.IsContextMenu )
                         x = ( x * -1 ) ;

FCKeditor/trunk/editor/_source/internals/fckdomtools.js

@@ -920 +920 @@
                 for ( var styleName in styleDict )
                         style[ styleName ] = styleDict[ styleName ] ;
+        },
+
+        GetCurrentElementStyle : function( w, element, attrName )
+        {
+                if ( FCKBrowserInfo.IsIE )
+                        return element.currentStyle[attrName] ;
+                else
+                        return w.getComputedStyle( element, '' )[attrName] ;
+        },
+
+        GetPositionedAncestor : function( w, element )
+        {
+                var currentElement = element ;
+                while ( currentElement != currentElement.ownerDocument.documentElement )
+                {
+                        if ( this.GetCurrentElementStyle( w, currentElement, 'position' ) != 'static' )
+                                return currentElement ;
+                        currentElement = currentElement.parentNode ;
+                }
+                return null ;
         }
 } ;