Changeset 1320

Timestamp:

2008-01-15 13:12:05 (2 years ago)

Author:

fredck

Message:

The current IFRAME position is now saved on mouse down. The new positions are then saved in a variable while moving, so we don't have to retrieve the current IFRAME position from computed styles on each call to the function. The dragMouseMoveHandler function is now more than 3 times faster.

Files:

• FCKeditor/branches/features/floating_dialog/editor/fckdialog.html (modified) (3 diffs)

FCKeditor/branches/features/floating_dialog/editor/fckdialog.html

@@ -277 +277 @@
 {
         var registeredWindows = [] ;
-        var lastCoords = null ;
+        var lastCoords ;
+        var currentPos ;
         
         var cleanUpHandlers = function()
@@ -296 +297 @@
                         evt = FCKTools.GetElementDocument( this ).parentWindow.event ;
 
-                var currentCoords = {'x' : evt.screenX, 'y' : evt.screenY};
-                var dx = currentCoords.x - lastCoords.x;
-                var dy = currentCoords.y - lastCoords.y;
-                lastCoords = currentCoords;
-
-                var x = parseInt( FCKDomTools.GetCurrentElementStyle( Args().TopWindow, frameElement, 'left' ) ) + dx ;
-                var y = parseInt( FCKDomTools.GetCurrentElementStyle( Args().TopWindow, frameElement, 'top' ) ) + dy ;
-
-                frameElement.style.left = x + 'px' ;
-                frameElement.style.top  = y + 'px' ;
+                // Updated the last coordinates.
+                var currentCords =
+                {
+                        x : evt.screenX,
+                        y : evt.screenY
+                } ;
+
+                currentPos =
+                {
+                        x : currentPos.x + ( currentCords.x - lastCoords.x ),
+                        y : currentPos.y + ( currentCords.y - lastCoords.y )
+                } ;
+
+                lastCoords = currentCords ;
+
+                frameElement.style.left = currentPos.x + 'px' ;
+                frameElement.style.top  = currentPos.y + 'px' ;
 
                 if ( evt.preventDefault )
@@ -340 +348 @@
                                 return ;
 
-                        lastCoords = {'x' : evt.screenX, 'y' : evt.screenY} ;
+                        lastCoords = 
+                        {
+                                x : evt.screenX, 
+                                y : evt.screenY
+                        } ;
+
+                        // Save the current IFRAME position.
+                        currentPos = 
+                        {
+                                x : parseInt( FCKDomTools.GetCurrentElementStyle( Args().TopWindow, frameElement, 'left' ) ),
+                                y : parseInt( FCKDomTools.GetCurrentElementStyle( Args().TopWindow, frameElement, 'top' ) )
+                        } ;
 
                         for ( var i = 0 ; i < registeredWindows.length ; i++ )