Changeset 1434

Timestamp:

2008-01-28 03:47:17 (2 years ago)

Author:

martinkou

Message:

Fixed #1514 : Floating panels attached to a shared toolbar among multiple FCKeditor instances are no longer misplaced when the editing areas are absolutely or relatively positioned.

Location:

FCKeditor/trunk

Files:

• editor/_source/classes/fckpanel.js (modified) (5 diffs)
• editor/_source/classes/fcktoolbarpanelbutton.js (modified) (3 diffs)
• editor/_source/commandclasses/fcktextcolorcommand.js (modified) (1 diff)
• editor/_source/internals/fck.js (modified) (1 diff)
• editor/_source/internals/fcktoolbarset.js (modified) (1 diff)
• _whatsnew.html (modified) (1 diff)

FCKeditor/trunk/editor/_source/classes/fckpanel.js

@@ -65 +65 @@
                         } ) ;
 
-                if ( this._Window == window.parent && window.frameElement )
-                {
-                        var scrollPos = null ;
-                        if ( FCKBrowserInfo.IsGecko && FCK && FCK.EditorDocument )
-                                scrollPos = [ FCK.EditorDocument.body.scrollLeft, FCK.EditorDocument.body.scrollTop ] ;
-                        window.frameElement.parentNode.insertBefore( oIFrame, window.frameElement ) ;
-                        if ( scrollPos )
-                        {
-                                var restoreFunc = function()
-                                {
-                                        FCK.EditorDocument.body.scrollLeft = scrollPos[0] ;
-                                        FCK.EditorDocument.body.scrollTop = scrollPos[1] ;
-                                }
-                                setTimeout( restoreFunc, 500 ) ;
-                        }
-                }
-                else
-                        this._Window.document.body.appendChild( oIFrame ) ;
+                this._Window.document.body.appendChild( oIFrame ) ;
 
                 var oIFrameWindow = oIFrame.contentWindow ;
@@ -196 +179 @@
 
                 // Be sure we'll not have more than one Panel opened at the same time.
-                if ( FCKPanel._OpenedPanel )
-                        FCKPanel._OpenedPanel.Hide() ;
+                // Do not unlock focus manager here because we're displaying another floating panel
+                // instead of returning the editor to a "no panel" state (Bug #1514).
+                if ( FCK.ToolbarSet.CurrentInstance.GetInstanceObject( 'FCKPanel' )._OpenedPanel && 
+                                FCK.ToolbarSet.CurrentInstance.GetInstanceObject( 'FCKPanel' )._OpenedPanel != this )
+                        FCK.ToolbarSet.CurrentInstance.GetInstanceObject( 'FCKPanel' )._OpenedPanel.Hide( false, true ) ;
 
                 FCKDomTools.SetElementStyles( eMainNode,
@@ -262 +248 @@
                 }
 
-                if ( x < 0 )
-                         x = 0 ;
-
                 // Set the context menu DIV in the specified location.
                 FCKDomTools.SetElementStyles( this._IFrame,
@@ -272 +255 @@
                         } ) ;
 
-                var iWidth      = iMainWidth ;
-                var iHeight     = eMainNode.offsetHeight ;
-
-                this._IFrame.width      = iWidth ;
-                this._IFrame.height = iHeight ;
-
-                // Move the focus to the IFRAME so we catch the "onblur".
-                this._IFrame.contentWindow.focus() ;
-
-                FCKPanel._OpenedPanel = this ;
-        }
-
-        this._IsOpened = true ;
+                var me = this ;
+                var resizeFunc = function()
+                {
+                        var iWidth = eMainNode.offsetWidth || eMainNode.firstChild.offsetWidth ;
+                        var iHeight = eMainNode.offsetHeight ;
+                        me._IFrame.width = iWidth ;
+                        me._IFrame.height = iHeight ;
+                
+                        // Move the focus to the IFRAME so we catch the "onblur".
+                        me._IFrame.contentWindow.focus() ;
+                        me._IsOpened = true ;
+                }
+                setTimeout( resizeFunc, 1 ) ;
+
+                FCK.ToolbarSet.CurrentInstance.GetInstanceObject( 'FCKPanel' )._OpenedPanel = this ;
+        }
 
         FCKTools.RunFunction( this.OnShow, this ) ;
 }
 
-FCKPanel.prototype.Hide = function( ignoreOnHide )
+FCKPanel.prototype.Hide = function( ignoreOnHide, ignoreFocusManagerUnlock )
 {
         if ( this._Popup )
@@ -299 +285 @@
 
                 // Enable the editor to fire the "OnBlur".
-                if ( typeof( FCKFocusManager ) != 'undefined' )
+                if ( typeof( FCKFocusManager ) != 'undefined' && !ignoreFocusManagerUnlock )
                         FCKFocusManager.Unlock() ;
 

FCKeditor/trunk/editor/_source/classes/fcktoolbarpanelbutton.js

@@ -49 +49 @@
 
         var oPanel = FCK.ToolbarSet.CurrentInstance.Commands.GetCommand( this.CommandName )._Panel ;
+        this.RegisterPanel( oPanel ) ;
+}
+
+FCKToolbarPanelButton.prototype.RegisterPanel = function( oPanel )
+{
+        if ( oPanel._FCKToolbarPanelButton )
+                return ;
+
         oPanel._FCKToolbarPanelButton = this ;
 
@@ -55 +63 @@
         eLineDiv.style.top = '0px' ;
 
-        var eLine = this.LineImg = eLineDiv.appendChild( oPanel.Document.createElement( 'IMG' ) ) ;
+        var eLine = oPanel._FCKToolbarPanelButtonLineDiv = eLineDiv.appendChild( oPanel.Document.createElement( 'IMG' ) ) ;
         eLine.className = 'TB_ConnectionLine' ;
         eLine.style.position = 'absolute' ;
@@ -75 +83 @@
         oButton._UIButton.ChangeState( FCK_TRISTATE_ON ) ;
 
-        oButton.LineImg.style.width = ( e.offsetWidth - 2 ) + 'px' ;
+        // oButton.LineImg.style.width = ( e.offsetWidth - 2 ) + 'px' ;
 
-        FCK.ToolbarSet.CurrentInstance.Commands.GetCommand( oButton.CommandName ).Execute( 0, e.offsetHeight - 1, e ) ; // -1 to be over the border
+        var oCommand = FCK.ToolbarSet.CurrentInstance.Commands.GetCommand( oButton.CommandName ) ;
+        var oPanel = oCommand._Panel ;
+        oPanel._FCKToolbarPanelButtonLineDiv.style.width = ( e.offsetWidth - 2 ) + 'px' ;
+        oCommand.Execute( 0, e.offsetHeight - 1, e ) ; // -1 to be over the border
 }
 

FCKeditor/trunk/editor/_source/commandclasses/fcktextcolorcommand.js

@@ -43 +43 @@
         this._Panel.MainNode.className = 'FCK_Panel' ;
         this._CreatePanelBody( this._Panel.Document, this._Panel.MainNode ) ;
+        FCK.ToolbarSet.ToolbarItems.GetItem( this.Name ).RegisterPanel( this._Panel ) ;
 
         FCKTools.DisableSelection( this._Panel.Document.body ) ;

FCKeditor/trunk/editor/_source/internals/fck.js

@@ -33 +33 @@
         DataProcessor   : new FCKDataProcessor(),
 
+        GetInstanceObject       : (function()
+        {
+                var w = window ;
+                return function( name )
+                {
+                        return w[name] ;
+                }
+        })(),
+
         AttachToOnSelectionChange : function( functionPointer )
         {

FCKeditor/trunk/editor/_source/internals/fcktoolbarset.js

@@ -108 +108 @@
 
         oToolbarSet.CurrentInstance = FCK ;
+        if ( !oToolbarSet.ToolbarItems )
+                oToolbarSet.ToolbarItems = FCKToolbarItems ;
 
         FCK.AttachToOnSelectionChange( oToolbarSet.RefreshItemsState ) ;

FCKeditor/trunk/_whatsnew.html

@@ -65 +65 @@
                 <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/1707">#1707</a>] The editor
                         no longer hangs when operating on documents imported from Microsoft Word.</li>
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/1514">#1514</a>] Floating panels
+                        attached to a shared toolbar among multiple FCKeditor instances are no longer misplaced
+                        when the editing areas are absolutely or relatively positioned.</li>
         </ul>
         <p>