Changeset 1687

Timestamp:

2008-03-10 03:33:25 (2 years ago)

Author:

martinkou

Message:

Fixed #1828 : Fixed the issue where it is still possible that the pattern logic in Find/Replace Dialog would go wrong with xxxxxy (for any distinct characters x and y, and for any 2+ repetitions of x) patterns.

Files:

• FCKeditor/trunk/editor/dialog/fck_replace.html (modified) (5 diffs)

FCKeditor/trunk/editor/dialog/fck_replace.html

@@ -232 +232 @@
 // Knuth-Morris-Pratt Algorithm for stream input
 KMP_NOMATCH = 0 ;
-KMP_STARTED = 1 ;
-KMP_ADVANCED = 2 ;
-KMP_MATCHED = 3 ;
+KMP_ADVANCED = 1 ;
+KMP_MATCHED = 2 ;
 function KmpMatch( pattern, ignoreCase )
 {
@@ -269 +268 @@
                                         return KMP_MATCHED;
                                 }
-                                return this._State > 1 ? KMP_ADVANCED : KMP_STARTED ;
+                                return KMP_ADVANCED ;
                         }
                         else if ( this._State == 0 )
@@ -292 +291 @@
         var matchState = KMP_NOMATCH ;
         var matchBookmark = null ;
+        var matchBookmarkStart = [] ;
 
         // Match finding.
@@ -306 +306 @@
                                 {
                                         matcher.Reset();
-                                        matchBookmark = null ;
+                                        matchBookmarkStart = [] ;
                                 }
                         }
@@ -316 +316 @@
                                 // So delete any positional information.
                                 if ( matchState == KMP_NOMATCH )
-                                        matchBookmark = null ;
-                                // The currently scanned character is a possible start, so mark down the starting position.
-                                else if ( matchState == KMP_STARTED )
-                                        matchBookmark = { Start : cursor.concat( [] ) } ;
+                                        matchBookmarkStart = [] ;
+                                // We've matched something, but it's not a complete match, so let's just mark down the position for backtracking later.
+                                else if ( matchState == KMP_ADVANCED )
+                                {
+                                        matchBookmarkStart.push( cursor.concat( [] ) ) ;
+                                        if ( matchBookmarkStart.length > matcher._State )
+                                                matchBookmarkStart.shift() ;
+                                }
                                 // Found a complete match! Mark down the ending position as well.
                                 else if ( matchState == KMP_MATCHED )
                                 {
-                                        // It is possible to get a KMP_MATCHED without KMP_STARTED when the match pattern is only 1 character.
+                                        // It is possible to get a KMP_MATCHED without KMP_ADVANCED when the match pattern is only 1 character.
                                         // So need to check and mark down the starting position as well.
-                                        if ( matchBookmark == null )
-                                                matchBookmark = { Start : cursor.concat( [] ) } ;
-
-                                        matchBookmark.End = cursor.concat( [] ) ;
+                                        if ( matchBookmarkStart.length == 0 )
+                                                matchBookmarkStart = [cursor.concat( [] )] ;
+
+                                        matchBookmark = { 'Start' : matchBookmarkStart.shift(), 'End' : cursor.concat( [] ) } ;
                                         matchBookmark.End[ matchBookmark.End.length - 1 ]++;