Changeset 1718

Timestamp:

2008-03-18 10:09:43 (4 months ago)

Author:

fredck

Message:

Fixed #2016 : The Link dialog now properly select the first field when opening it to modify mailto or anchor links. This problem was also throwing an error in IE.

Location:

FCKeditor/trunk

Files:

• editor/dialog/common/fck_dialog_common.js (modified) (1 diff)
• editor/dialog/fck_link/fck_link.js (modified) (1 diff)
• _whatsnew.html (modified) (1 diff)

FCKeditor/trunk/editor/dialog/common/fck_dialog_common.js

@@ -105 +105 @@
         var element = GetE( elementId ) ;
         element.focus() ;
-        element.select() ;
+
+        // element.select may not be available for some fields (like <select>).
+        if ( element.select )
+                element.select() ;
 }
 

FCKeditor/trunk/editor/dialog/fck_link/fck_link.js

@@ -160 +160 @@
         // Activate the "OK" button.
         dialog.SetOkButton( true ) ;
-        SelectField( 'txtUrl' ) ;
+        
+        // Select the first field.
+        switch( GetE('cmbLinkType').value )
+        {
+                case 'url' :
+                        SelectField( 'txtURL' ) ;
+                        break ;
+                case 'email' :
+                        SelectField( 'txtEMailAddress' ) ;
+                        break ;
+                case 'anchor' : 
+                        if ( GetE('divSelAnchor').style.display != 'none' )
+                                SelectField( 'cmbAnchorName' ) ;
+                        else
+                                SelectField( 'cmbLinkType' ) ;
+        }
 }
 

FCKeditor/trunk/_whatsnew.html

@@ -85 +85 @@
                 <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/2011">#2011</a>] Internal
                         CSS &lt;style&gt; tags where being outputted when FullPage=true.</li>
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/2016">#2016</a>] The Link
+                        dialog now properly select the first field when opening it to modify mailto or anchor
+                        links. This problem was also throwing an error in IE.</li>
         </ul>
         <h3>