Changeset 2144

Timestamp:

2008-06-26 11:42:50 (21 months ago)

Author:

martinkou

Message:

Fixed #2323 : Fixed the issue where the show blocks command loses the current selection from the view area when editing a long document.

Location:

FCKeditor/trunk

Files:

• editor/_source/commandclasses/fckshowblocks.js (modified) (1 diff)
• editor/_source/internals/fckdomtools.js (modified) (1 diff)
• _whatsnew.html (modified) (1 diff)

FCKeditor/trunk/editor/_source/commandclasses/fckshowblocks.js

@@ -45 +45 @@
                 body.className += ' FCK__ShowBlocks' ;
 
+        if ( FCKBrowserInfo.IsIE )
+        {
+                try
+                {
+                        FCK.EditorDocument.selection.createRange().select() ;
+                }
+                catch ( e )
+                {}
+        }
+        else
+        {
+                var focus = FCK.EditorWindow.getSelection().focusNode ;
+                if ( focus.nodeType != 1 )
+                        focus = focus.parentNode ;
+                FCKDomTools.ScrollIntoView( focus, false ) ;
+        }
+
         FCK.Events.FireEvent( 'OnSelectionChange' ) ;
 }

FCKeditor/trunk/editor/_source/internals/fckdomtools.js

@@ -1005 +1005 @@
                 // Scroll the window to the desired position, if not already visible.
                 var currentScroll = FCKTools.GetScrollPosition( window ).Y ;
-                if ( offset > 0 && offset > currentScroll )
+                if ( offset > 0 && ( offset > currentScroll || offset < currentScroll - windowHeight ) )
                         window.scrollTo( 0, offset ) ;
         },

FCKeditor/trunk/_whatsnew.html

@@ -59 +59 @@
                         3, the entire page was scrolling when inserting block elements with the FCK.InsertElement
                         function, used by the Table and Horizontal Rule buttons.. </li>
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/2323">#2323</a>] Fixed the issue
+                        where the show blocks command loses the current selection from the view area when editing
+                        a long document.</li>
         </ul>
         <p>