Changeset 252

Timestamp:

2007-04-16 22:06:59 (3 years ago)

Author:

alfonsoml

Message:

Fix for #338, after creating a link we avoid leaving a br inside so it isn't so easy to select it in the next line.

Location:

FCKeditor/trunk

Files:

• editor/_source/internals/fck_ie.js (modified) (1 diff)
• _whatsnew.html (modified) (1 diff)

FCKeditor/trunk/editor/_source/internals/fck_ie.js

@@ -394 +394 @@
                                 oLink.href = url ;
                                 oLink.innerHTML = sInnerHtml ;          // Restore the innerHTML.
+
+                                // If the last child is a <br> move it outside the link or it will be too easy to select this link again #338
+                                if (oLink.lastChild.nodeName == 'BR' )
+                                {
+                                        // We move the br as a sibling after the link:
+                                        var oBR = oLink.lastChild ;
+                                        oLink.removeChild( oBR ) ;
+                                        // There's no insertAfter, so we insert before the next sibling
+                                        oLink.parentNode.insertBefore( oBR, oLink.nextSibling  );
+                                }
+
                                 return oLink ;
                         }

FCKeditor/trunk/_whatsnew.html

@@ -52 +52 @@
                         was being lost for images or comments only HTML inserted directly in the editor
                         source or loaded in the editor.</li>
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/338">#338</a>] Creating links in
+                        lines separated by &lt;br&gt; in IE can lead to a merge of the links.</li>
         </ul>
         <h3>