Changeset 338

Timestamp:

2007-05-30 23:37:52 (20 months ago)

Author:

alfonsoml

Message:

Fix for #258, the boolean values did get sent as "true" or "false" if the server locale wasn't English.

Location:

FCKeditor/trunk

Files:

• fckeditor.asp (modified) (2 diffs)
• _whatsnew.html (modified) (1 diff)

FCKeditor/trunk/fckeditor.asp

@@ -1 @@
-<!--
+<!--
  * FCKeditor - The text editor for Internet - http://www.fckeditor.net
  * Copyright (C) 2003-2007 Frederico Caldeira Knabben
@@ -188 +188 @@
 
         Private Function EncodeConfig( valueToEncode )
-                EncodeConfig = Replace( valueToEncode, "&", "%26" )
-                EncodeConfig = Replace( EncodeConfig , "=", "%3D" )
-                EncodeConfig = Replace( EncodeConfig , """", "%22" )
+                ' The locale of the asp server makes the conversion of a boolean to string different to "true" or "false"
+                ' so we must do it manually
+    If vartype(valueToEncode) = vbBoolean then 
+                        If valueToEncode=True Then
+                                EncodeConfig="True"
+                        Else
+                                EncodeConfig="False"
+                        End If 
+                Else
+                        EncodeConfig = Replace( valueToEncode, "&", "%26" )
+                        EncodeConfig = Replace( EncodeConfig , "=", "%3D" )
+                        EncodeConfig = Replace( EncodeConfig , """", "%22" )
+                End if                           
+
         End Function
 

FCKeditor/trunk/_whatsnew.html

@@ -108 +108 @@
                         form had a button named "submit" the "Save" command didn't work in Firefox.</li>
                 <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/414">#414</a>] If tracing was 
-                globally enabled in Asp.Net 2.0 then the Asp.Net connector did fail.</li>
+                        globally enabled in Asp.Net 2.0 then the Asp.Net connector did fail.</li>
                 <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/520">#520</a>] The "Select
                         Field" properties dialog was not correctly handling select options with &amp;, &lt;
                         and &gt;.</li>
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/258">#258</a>] The Asp integration 
+                        didn't pass boolean values in English, using instead the locale of the server and failing.</li>
         </ul>
         <h3>