Changeset 341 for FCKeditor/trunk/editor/dialog/fck_anchor.html

Timestamp:

2007-05-31 13:53:34 (20 months ago)

Author:

fredck

Message:

Fixed #220 : The creation of links or anchors in a selection that results on more than a single link created will not anymore leave temporary links in the source.

Files:

• FCKeditor/trunk/editor/dialog/fck_anchor.html (modified) (1 diff)

FCKeditor/trunk/editor/dialog/fck_anchor.html

@@ -111 +111 @@
 
         // Create a new anchor preserving the current selection
-        oAnchor = oEditor.FCK.CreateLink( '#' ) ;
-        if ( !oAnchor )
+        var aNewAnchors = oEditor.FCK.CreateLink( '#' ) ;
+
+        if ( aNewAnchors.length == 0 )
         {
                 // Nothing was selected, so now just create a normal A
-                oAnchor = oEditor.FCK.InsertElement( 'a' ) ;
+                aNewAnchors.push( oEditor.FCK.InsertElement( 'a' ) ) ;
         }
         else
         {
                 // Remove the fake href
-                oAnchor.removeAttribute( 'href' ) ;
-        }
-        // Set the name
-        oAnchor.name = sNewName ;
-
-        // IE does require special processing to show the Anchor's image
-        // Opera doesn't allow to select empty anchors
-        if ( FCKBrowserInfo.IsIE || FCKBrowserInfo.IsOpera )
-        {
-                if ( oAnchor.innerHTML != '' )
+                for ( var i = 0 ; i < aNewAnchors.length ; i++ )
+                        aNewAnchors[i].removeAttribute( 'href' ) ;
+        }
+
+        // More than one anchors may have been created, so interact through all of them (see #220).
+        for ( var i = 0 ; i < aNewAnchors.length ; i++ )
+        {
+                oAnchor = aNewAnchors[i] ;
+
+                // Set the name
+                oAnchor.name = sNewName ;
+
+                // IE does require special processing to show the Anchor's image
+                // Opera doesn't allow to select empty anchors
+                if ( FCKBrowserInfo.IsIE || FCKBrowserInfo.IsOpera )
                 {
-                        if ( FCKBrowserInfo.IsIE )
-                                oAnchor.className += ' FCK__AnchorC' ;
+                        if ( oAnchor.innerHTML != '' )
+                        {
+                                if ( FCKBrowserInfo.IsIE )
+                                        oAnchor.className += ' FCK__AnchorC' ;
+                        }
+                        else
+                        {
+                                // Create a fake image for both IE and Opera
+                                var oImg = oEditor.FCKDocumentProcessor_CreateFakeImage( 'FCK__Anchor', oAnchor.cloneNode(true) ) ;
+                                oImg.setAttribute( '_fckanchor', 'true', 0 ) ;
+
+                                oAnchor.parentNode.insertBefore( oImg, oAnchor ) ;
+                                oAnchor.parentNode.removeChild( oAnchor ) ;
+                        }
+
                 }
-                else
-                {
-                        // Create a fake image for both IE and Opera
-                        var oImg = oEditor.FCKDocumentProcessor_CreateFakeImage( 'FCK__Anchor', oAnchor.cloneNode(true) ) ;
-                        oImg.setAttribute( '_fckanchor', 'true', 0 ) ;
-
-                        oAnchor.parentNode.insertBefore( oImg, oAnchor ) ;
-                        oAnchor.parentNode.removeChild( oAnchor ) ;
-                }
-
         }