Changeset 344

Show
Ignore:
Timestamp:
2007-06-01 17:51:48 (20 months ago)
Author:
fredck
Message:

Fixed #281 : Custom toolbar buttons now render correctly in all skins.

Location:
FCKeditor/trunk
Files:
2 modified

Legend:

Unmodified
Added
Removed
  • FCKeditor/trunk/editor/_source/classes/fckicon.js

    r132 r344  
    8080        else                                    // It is using a single icon image. 
    8181        { 
    82                 // This is not working well with IE. See notes bellow. 
    83                 // <img class="TB_Button_Image" src="smiley.gif"> 
    84 //              eIcon = document.createElement( 'IMG' ) ; 
    85 //              eIcon.src = this.Path ? this.Path : FCK_SPACER_PATH ; 
     82                if ( FCKBrowserInfo.IsIE ) 
     83                { 
     84                        // IE makes the button 1px higher if using the <img> directly, so we 
     85                        // are changing to the <div> system to clip the image correctly. 
     86                        eIcon = document.createElement( 'DIV' ) ; 
    8687 
    87                 // IE makes the button 1px higher if using the <img> directly, so we 
    88                 // are changing to the <div> system to clip the image correctly. 
    89                 eIcon = document.createElement( 'DIV' ) ; 
    90  
    91                 eIconImage = eIcon.appendChild( document.createElement( 'IMG' ) ) ; 
    92                 eIconImage.src = this.Path ? this.Path : FCK_SPACER_PATH ; 
     88                        eIconImage = eIcon.appendChild( document.createElement( 'IMG' ) ) ; 
     89                        eIconImage.src = this.Path ? this.Path : FCK_SPACER_PATH ; 
     90                } 
     91                else 
     92                { 
     93                        // This is not working well with IE. See notes above. 
     94                        // <img class="TB_Button_Image" src="smiley.gif"> 
     95                        eIcon = document.createElement( 'IMG' ) ; 
     96                        eIcon.src = this.Path ? this.Path : FCK_SPACER_PATH ; 
     97                } 
    9398        } 
    9499 
  • FCKeditor/trunk/_whatsnew.html

    r343 r344  
    130130                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/220">#182</a>] [<a target="_blank" href="http://dev.fckeditor.net/ticket/220">#261</a>] [<a target="_blank" href="http://dev.fckeditor.net/ticket/220">#511</a>] Special characters, like percent signs or accented 
    131131                        chars, and spaces are now correctly returned by the File Browser.</li> 
     132                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/281">#281</a>] Custom 
     133                        toolbar buttons now render correctly in all skins.</li> 
    132134        </ul> 
    133135        <h3>