Changeset 401

Timestamp:

2007-06-30 23:07:29 (17 months ago)

Author:

fredck

Message:

Fixed #497: Fixed EMBED attributes handling in IE. The EMBED tag is now being "protected", which makes IE handling its attributes correctly (not loosing them actually).

Location:

FCKeditor/trunk

Files:

• editor/_source/internals/fckdocumentprocessor.js (modified) (2 diffs)
• editor/_source/internals/fck.js (modified) (1 diff)
• _whatsnew.html (modified) (1 diff)

FCKeditor/trunk/editor/_source/internals/fckdocumentprocessor.js

@@ -144 +144 @@
                         var oCloned = oEmbed.cloneNode( true ) ;
 
-                        // On IE, some properties are not getting clonned properly, so we
-                        // must fix it. Thanks to Alfonso Martinez.
-                        if ( FCKBrowserInfo.IsIE )
-                        {
-                                var aAttributes = [ 'scale', 'play', 'loop', 'menu', 'wmode', 'quality' ] ;
-                                for ( var iAtt = 0 ; iAtt < aAttributes.length ; iAtt++ )
-                                {
-                                        var oAtt = oEmbed.getAttribute( aAttributes[iAtt] ) ;
-                                        if ( oAtt ) oCloned.setAttribute( aAttributes[iAtt], oAtt ) ;
-                                }
-                                // It magically gets lost after reading it in oType
-                                oCloned.setAttribute( 'type', oType.nodeValue ) ;
-                        }
-
                         var oImg = FCKDocumentProcessor_CreateFakeImage( 'FCK__Flash', oCloned ) ;
                         oImg.setAttribute( '_fckflash', 'true', 0 ) ;
@@ -165 +151 @@
                         oEmbed.parentNode.insertBefore( oImg, oEmbed ) ;
                         oEmbed.parentNode.removeChild( oEmbed ) ;
-
-//                      oEmbed.setAttribute( '_fcktemp', 'true', 0) ;
-//                      oEmbed.style.display = 'none' ;
-//                      oEmbed.hidden = true ;
                 }
         }

FCKeditor/trunk/editor/_source/internals/fck.js

@@ -298 +298 @@
                 // IE doesn't support <abbr> and it breaks it. Let's protect it.
                 if ( FCKBrowserInfo.IsIE )
-                        sTags += sTags.length > 0 ? '|ABBR|XML' : 'ABBR|XML' ;
+                        sTags += sTags.length > 0 ? '|ABBR|XML|EMBED' : 'ABBR|XML|EMBED' ;
 
                 var oRegex ;

FCKeditor/trunk/_whatsnew.html

@@ -56 +56 @@
                         Patch 1511298</a>] The CF Component failed on CFMX 6.0</li>
                 <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/639">#639</a>] If the 
-                        FCKConfig.DefaultLinkTarget setting was missing in fckconfig.js the links has target="undefined"</li>
+                        FCKConfig.DefaultLinkTarget setting was missing in fckconfig.js the links has target="undefined".</li>
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/497">#497</a>] Fixed EMBED
+                        attributes handling in IE.</li>
         </ul>
         <h3>