Changeset 623

Timestamp:

2007-08-03 12:56:52 (3 years ago)

Author:

fredck

Message:

Small change to [608] (fix for #141), to avoid making changes in the selection. Also, moved it to a dedicated function to avoid code duplications.

Files:

• FCKeditor/trunk/editor/_source/classes/fckeditingarea.js (modified) (4 diffs)

FCKeditor/trunk/editor/_source/classes/fckeditingarea.js

@@ -175 +175 @@
                 oDoc.body.removeAttribute( "disabled" ) ;
 
-                var delayedExec = function()
-                {
-                        var range = oDoc.selection.createRange() ;
-                        range.moveEnd( "character", 1 ) ;
-                        range.select() ;
-                        range.collapse( true ) ;
-                        range.select() ;
-                }
-                setTimeout( delayedExec, 1 ) ;
-
                 /* The following commands don't throw errors, but have no effect.
                 oDoc.execCommand( 'AutoDetect', false, false ) ;
@@ -274 +264 @@
                         // http://sourceforge.net/tracker/index.php?func=detail&aid=1567060&group_id=75348&atid=543653
                         if ( FCKBrowserInfo.IsIE && this.Document.hasFocus() )
-                                // In IE it can happen that the document is in theory focused but the active element is outside it
-                                this.Document.body.setActive() ;
+                                this._EnsureFocusIE() ;
 
                         if ( FCKBrowserInfo.IsSafari )
@@ -285 +274 @@
                                 // In IE it can happen that the document is in theory focused but the active element is outside it
                                 if ( FCKBrowserInfo.IsIE )
-                                        this.Document.body.setActive() ;
+                                        this._EnsureFocusIE() ;
                         }
                 }
@@ -298 +287 @@
         }
         catch(e) {}
+}
+
+FCKEditingArea.prototype._EnsureFocusIE = function()
+{
+        // In IE it can happen that the document is in theory focused but the active element is outside it
+        this.Document.body.setActive() ;
+
+        // Kludge for #141... yet more code to workaround IE bugs
+        var range = this.Document.selection.createRange() ;
+        range.moveEnd( "character", 1 ) ;
+        range.select() ;
+        range.moveEnd( "character", -1 ) ;
+        range.select() ;
 }