Ticket #1502 (closed Bug: fixed)

Opened 13 months ago

Last modified 9 months ago

Remove format doesn't remove attributes

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6
Component: Core : Styles Version: FCKeditor 2.5 Beta
Keywords: Confirmed Review+ Cc:

Description

The "Remove format" introduced in #75 doesn't remove any attribute, so it leaves the class and styles, so in the end the result is almost no clean up at all.

This is a list of attributes that should be cleaned at least to have some clean output:

  • class / className
  • style
  • lang
  • width
  • height
  • align
  • v:shapes
  • x:str
  • x:num
  • hspace
  • valign

Attachments

1502.patch (1.8 KB) - added by alfonsoml 9 months ago.
Proposed SVN patch
1502_2.patch (3.1 KB) - added by alfonsoml 9 months ago.
Revised patch

Change History

Changed 9 months ago by w.olchawa

  • keywords Confirmed added

Confirmed in IE and FF2 using version 2.5 SVN Build 18185

Changed 9 months ago by alfonsoml

Proposed SVN patch

Changed 9 months ago by alfonsoml

  • keywords Review? added
  • owner set to alfonsoml
  • status changed from new to assigned

The patch does take care of removing that list of attributes (it's configurable in fckconfig.js) when the remove Format is executed, so the output code is really clean.

Changed 9 months ago by alfonsoml

Revised patch

Changed 9 months ago by fredck

  • keywords Review+ added; Review? removed

Changed 9 months ago by alfonsoml

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone set to FCKeditor 2.6

Fixed with [1603]

Note: See TracTickets for help on using tickets.