Ticket #1613 (closed Bug: fixed)

Opened 5 months ago

Last modified 3 months ago

Extra div wrapping the editor instance

Reported by: alfonsoml Assigned to: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version:
Keywords: Review+ Cc:

Description

This is not about the content generated by the editor, but just the HTML that does in fact becomes the editor. The call to FCKeditor.prototype.CreateHtml returns a <div> that wraps some hidden inputs and a iframe or textarea.

From my point of view that div isn't necessary so it could be removed as it makes a little harder to get 100% height in standards mode and doesn't provide anything useful.

Attachments

1613.patch (7.0 kB) - added by alfonsoml on 02/10/08 19:20:02.
Proposed SVN patch

Change History

12/03/07 22:36:24 changed by dustball

Comment - this makes sense. I cannot think of any reason to have it.

After all, people can easily wrap the output of CreateHtml with their own DIV, if they really want it.

02/09/08 00:08:15 changed by alfonsoml

  • owner set to alfonsoml.
  • status changed from new to assigned.

02/10/08 19:20:02 changed by alfonsoml

  • attachment 1613.patch added.

Proposed SVN patch

02/10/08 19:20:49 changed by alfonsoml

  • keywords set to Review?.

The patch does remove the div generated with the different integration methods.

02/11/08 10:39:18 changed by fredck

  • keywords changed from Review? to Review+.
  • milestone set to FCKeditor 2.6.

I'm sure this things had some sense in the past. I recall we were used to not have that <div>, but for some reason it has been introduced, in the early beginnings (so, prone to mistakes).

Unfortunately we didn't have SVN to help us explaining anything about it. It makes no sense to me too, so let's drop it.

Please include the changelog entry for it.

02/11/08 19:11:09 changed by alfonsoml

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed with [1503]