Ticket #1641 (closed Bug: fixed)

Opened 12 months ago

Last modified 10 months ago

FCKBrowserInfo.IsIE7 is not ready for IE8

Reported by: fredck Owned by: fredck
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version: FCKeditor 2.5
Keywords: Review+ Cc:

Description

Our current sniffing for IE7 is not ready for IE8. It works for IE7 only, but for us it should be IE7+.

Attachments

1641.patch (0.6 KB) - added by fredck 12 months ago.
1641_2.patch (0.6 KB) - added by fredck 12 months ago.
1641_3.patch (0.6 KB) - added by fredck 11 months ago.

Change History

Changed 12 months ago by fredck

  Changed 12 months ago by fredck

  • keywords Review? added
  • status changed from new to assigned

The proposed patch should work on all future IE versions, even if the agent string changes. It is completely based on conditional compilation.

follow-up: ↓ 3   Changed 12 months ago by alfonsoml

  • keywords Review- added; Review? removed

The JScript version isn't really that coupled with the browser. It's possible to install the JScript 5.7 library in windows 2000 or XP with IE 6: http://blogs.msdn.com/jscript/archive/2007/08/12/windows-script-5-7-released-for-windows-2000-windows-xp-and-windows-2003-server.aspx

Yes, most people won't do that, but a few ones will and they will have a hard time to understand why FCKeditor fails in some computers.

Also, IE8 is just a name, we don't know absolutely nothing about it: features (it has been said that it will have a new rendering engine), bugs, predicted release dates...

Changed 12 months ago by fredck

in reply to: ↑ 2   Changed 12 months ago by fredck

  • keywords Review? added; Review- removed

Replying to alfonsoml:

The JScript version isn't really that coupled with the browser. It's possible to install the JScript 5.7 library in windows 2000 or XP with IE 6

Your assumption is correct Alfonso. We can't rely on the JScript version.

Also, IE8 is just a name, we don't know absolutely nothing about it: features (it has been said that it will have a new rendering engine), bugs, predicted release dates...

We must at least expect that FCKeditor will run on IE8 as in IE7, not degrading it to IE6.


I've added a patch that uses the good and old userAgent parsing. Based on the MS documentation for the user agent and the IE7 user agent choice explanation, we can safely predict that IE8 will have the same "Version Token" syntax: MSIE 8.0.

I've also thought about detecting the "XMLHttpRequest" object, but it is possible to disable it in the IE7 settings panel.

  Changed 12 months ago by alfonsoml

  • keywords Review+ added; Review? removed

The new patch looks safe

  Changed 12 months ago by fredck

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [1191]. Click here for more info about our SVN system.

Changed 11 months ago by fredck

  Changed 11 months ago by fredck

  • keywords Review? added; Review+ removed
  • status changed from closed to reopened
  • resolution fixed deleted

I've simplified the regex with a new patch. We don't need the precise version number to check it. Only the major version is ok.

  Changed 11 months ago by alfonsoml

  • keywords Review+ added; Review? removed

ok, simpler is better.

  Changed 10 months ago by fredck

  • status changed from reopened to closed
  • resolution set to fixed

Committed the latest patch with [1403]. The new IE6 check has been also changed to reflect the same proposed solution.

Note: See TracTickets for help on using tickets.