Safari: new links do not appear in editor unless text is made into a link

[designfu]

Reproduce:

• Visit any FCKeditor release, including nightly as of 12/20/07.
• Do not select any text in the editor. (Does work when you select text)
• Click Link button.
• Enter any information.
• Click OK.

Problem: Link does not appear.

System: Mac OS X/Intel, unmodified Safari 3.0.2.

[w.olchawa]

Confirmed in Safari 3.0.4 (523.15) using 2.5.1 and 2.5 SVN Build 18195 versions

[martinkou]

Tidied up the description.

[moonpool]

Confirmed in Safari 3.1 also Any chance this bug can be fixed soon - or reclassified as High Priority? it seems like core functionality to me.

[alfonsoml]

This is a regression of [1096]

[alfonsoml]

Proposed SVN patch

[fredck]

I can't understand the (url != '#' ? url : '') in the patch... when is url supposed to be '#'?

Also, the real problem is that, only for Safari, FCK.CreateLink will create and return a link for a collapsed selection. All other browsers will not create that link. A side effect of it is that the link results for collapsed selections will be different on Safari. In that browser, anchors will have the "#", and e-mails will show the "mailto:" and search part of the link.

So, the correct solution would be making FCK.CreateLink behave in the same way for all browsers. I'll be attaching another patch proposal to try to achieve it.

[fredck]

Fixed a typo in the comments

[fredck]

Damned! I've used the wrong keyword... again... and again. Correcting it.

[alfonsoml]

Replying to fredck:

I can't understand the (url != '#' ? url : '') in the patch... when is url supposed to be '#'?

From the anchor dialog, this function was called with url = '#', and this way it seemed to be an easy workaround (not a real solutio)

Also, the real problem is that, only for Safari, FCK.CreateLink will create and return a link for a collapsed selection. All other browsers will not create that link. A side effect of it is that the link results for collapsed selections will be different on Safari. In that browser, anchors will have the "#", and e-mails will show the "mailto:" and search part of the link.

Yes, I noticed it, and I tried to leave the browser create the link in that situation, although I wasn't really proud of the solution.

This one on the other side looks like it will solve all the problems as all the browsers (even future ones) will have the same behavior.

[fredck]

Fixed with [1997]. Click here for more info about our SVN system.