Ticket #1707 (closed Bug: fixed)

Opened 5 months ago

Last modified 3 months ago

IE : Loop while formatting Word pasted data

Reported by: oliveira_lcs Assigned to: martinkou
Priority: High Milestone: FCKeditor 2.6
Component: General Version: FCKeditor 2.5
Keywords: IE Review+ Cc:

Description

Hi,

I´m getting this bug since release 2.5, aparentely due to a javascript loop on text format commands. The page freezes and returns a message asking me to stop the script that is taking too long to run. That also happens on the demo page for this site when you put a long text (it doesn´t need to be that long), containing paragraphs with different text formats, select it all and try to do any formatting with it, such as right aligning.

I´m using Internet Explorer 6.0 and Windows XP.

Hope you find a solution on that enableing me to upgrade FCKEditor, solving most of the problems I have on the previous versions.

Thanks,

Luís

Attachments

bug_fckeditor.doc (179.5 kB) - added by oliveira_lcs on 12/26/07 16:39:22.
Sample Data and Screenshot
1707.patch (1.0 kB) - added by martinkou on 01/25/08 09:17:05.
Proposed patch for fixing #1707.
1707_2.patch (0.9 kB) - added by martinkou on 01/25/08 09:29:41.
Simplified patch for fixing #1707.

Change History

12/26/07 16:39:22 changed by oliveira_lcs

  • attachment bug_fckeditor.doc added.

Sample Data and Screenshot

12/28/07 11:32:21 changed by fredck

  • keywords set to Confirmed IE.
  • priority changed from Normal to High.
  • summary changed from PAGE FREEZES WHILE FORMATTING (JAVASCRIPT ERROR) to IE : Loop while formatting Word pasted data.
  • version set to FCKeditor 2.5.
  • milestone set to FCKeditor 2.6.

Confirmed with IE. No problem with other browsers.

I've reduced the TC for it:

  1. Load the following HTML: 
<p><b>SAMPLE DATA<o:p></o:p></b></p>
  1. Align the "SAMPLE DATA" paragraph to right.

The browser will loop.

It works well by removing the <b> or the MS Office <o:p> tags.

(follow-up: ↓ 3 ) 12/28/07 12:12:21 changed by oliveira_lcs

Remember that it also happens when you write text with lots of paragraphs, containing different formats, straight on fckeditor. It´s not necessarily a pasted data from word. Thanks again, Luís

(in reply to: ↑ 2 ) 12/28/07 12:37:03 changed by fredck

Replying to oliveira_lcs:

Remember that it also happens when you write text with lots of paragraphs, containing different formats, straight on fckeditor. It´s not necessarily a pasted data from word.

For that case Luis, we need the precise steps to reproduce it. We can only work on facts, not theories.

Thanks for the update.

12/28/07 12:52:00 changed by oliveira_lcs

You´re right. That happened to me on 2.5. I´ve tried to reproduce it on the actual demo page without success, so maybe it´s fixed for 2.5.1. Thank you and I hope you find a solution for the word pasted data soon.

01/04/08 16:11:50 changed by hespanhol

I found that it get in a loop at "while ( ( block = iterator.GetNextParagraph() ) )" in fckjustifycommands.js.

iterator.GetNextParagraph() keeps returning <B></B> while variable currentnode in function GetNextParagraph() have <B><?xml:namespace prefix = o /><o:p></o:p></B>

I guess it is a matter of deleting the empty tag <B></B> at the end of the function, I just dont know how to do it.

01/24/08 07:25:35 changed by martinkou

  • owner set to martinkou.
  • status changed from new to assigned.

01/25/08 09:17:05 changed by martinkou

  • attachment 1707.patch added.

Proposed patch for fixing #1707.

01/25/08 09:17:36 changed by martinkou

  • keywords changed from Confirmed IE to Review?.

01/25/08 09:29:41 changed by martinkou

  • attachment 1707_2.patch added.

Simplified patch for fixing #1707.

01/25/08 09:35:12 changed by fredck

  • keywords changed from Review? to Review+.

Please include the changelog entry when committing.

01/25/08 10:05:54 changed by martinkou

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed with [1409].

Click here for more info about our SVN system.

01/29/08 13:44:00 changed by oliveira_lcs

  • status changed from closed to reopened.
  • resolution deleted.

I just tested with the changed file and it still freezes while formatting. Guess it needs to be reviwed. Thank you once again, Luís

01/30/08 08:30:43 changed by martinkou

Hi Luís,

Did you apply the patch to our released source package or to the SVN source tree? I'm asking this because applying the patch to the release source package has no effect - the source code in the downloadable package is there for viewing purpose only, it is not loaded by the browser. The patch is only effective if you apply it to the SVN source tree.

01/30/08 09:57:53 changed by fredck

You may also try our nightly build.

01/30/08 10:06:15 changed by fredck

  • keywords changed from Review+ to IE Review+.
  • status changed from reopened to closed.
  • resolution set to fixed.

I've tested it with both the reported TC as well as with the reduced TC described in comment:1. It works for me on both cases.

Feel free to reopen it if it is still a problem. In that case, please provide the precise instructions to reproduce it.

01/30/08 17:47:13 changed by oliveira_lcs

It did work for the nightly build. Thank you!!!