Ticket #1728 (closed Bug: fixed)

Opened 4 months ago

Last modified 3 months ago

Opera: external toolbar is too small

Reported by: martinkou Assigned to: martinkou
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version: SVN
Keywords: Review+ Cc:

Description

This bug was discovered while I was working on #1514.

Reproduction procedure:

  1. Open sample11.html in Opera 9.50 build 9721 or later.
  2. Notice the toolbar only contains two visible rows, while it contains three in other browsers.

This ticket is expected to be fixed with #1514 as both the floating panel code and toolbar code is being reviewed and modified for the ticket.

Attachments

1728.patch (1.8 kB) - added by martinkou on 01/11/08 10:21:04.
Proposed patch for fixing #1728.
1728_2.patch (2.4 kB) - added by martinkou on 02/01/08 10:04:52.

Change History

01/11/08 08:24:38 changed by martinkou

A patch has been written for #1514 but it doesn't fix this bug yet, because #1514's patch is already fixing a bunch of issues. Another separate patch will be written for this bug instead.

01/11/08 10:21:04 changed by martinkou

  • attachment 1728.patch added.

Proposed patch for fixing #1728.

01/11/08 10:21:18 changed by martinkou

  • keywords changed from Confirmed Opera to Review?.

01/27/08 23:16:53 changed by alfonsoml

  • keywords changed from Review? to Review-.

Maybe it could be better to also make the window.onresize event work with the poller function, so if this kind of problem can happen also in that situation it's automatically protected.

02/01/08 10:04:52 changed by martinkou

  • attachment 1728_2.patch added.

02/01/08 10:05:44 changed by martinkou

  • keywords changed from Review- to Review?.

I've updated the patch so that both onload and onresize would use the same poller function to detect the correct size of the toolbar.

02/02/08 12:43:42 changed by alfonsoml

  • keywords changed from Review? to Review+.

02/04/08 05:12:49 changed by martinkou

  • status changed from new to closed.
  • resolution set to fixed.

Fixed with [1466].

Click here for more info about our SVN system.