Ticket #1782 (closed Bug: fixed)

Opened 4 months ago

Last modified 3 months ago

Freeze of whole IE-window when clicking radiobutton

Reported by: elburg Assigned to: martinkou
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version: FCKeditor 2.5.1
Keywords: Confirmed IE Review+ Cc:

Description

The code in the attached file produces a page with an fckeditor that freezes the whole IE window when you click on the radio button inside it. This occurs when you click the radio button while the focus is NOT in the fckeditor window. It also happens with checkboxes.

You can test it on http://faramir.proteon.nl/fcktest.html

This didn't happen in fckeditor 2.4.3, but happens in both fckeditor 2.5 and 2.5.1.

Browser: IE7 on Windows XP.

Attachments

fcktest.html (1.2 kB) - added by elburg on 01/24/08 16:59:48.
Example file
1782.patch (2.4 kB) - added by martinkou on 02/01/08 11:41:22.
1782_2.patch (1.7 kB) - added by fredck on 02/02/08 17:04:17.

Change History

01/24/08 16:59:48 changed by elburg

  • attachment fcktest.html added.

Example file

01/24/08 17:30:37 changed by w.olchawa

  • keywords set to Confirmed IE7.
  • version set to FCKeditor 2.5.1.

01/27/08 02:31:55 changed by martinkou

  • owner set to martinkou.
  • status changed from new to assigned.
  • milestone set to FCKeditor 2.6.

01/27/08 02:32:16 changed by martinkou

This bug is pretty severe so I'm targetting it to 2.6.

02/01/08 11:41:22 changed by martinkou

  • attachment 1782.patch added.

02/01/08 11:41:37 changed by martinkou

  • keywords changed from Confirmed IE7 to Review?.

02/01/08 11:47:08 changed by martinkou

The problem seems to come from IE instead of FCKeditor's code. What happened was when the radio button or checkbox in the editable area was clicked after the textbox was focused, IE somehow locked the mouse focus to the clicked button and couldn't release it unless you took the focus away from the IE window.

The solution in my patch was to make the radio button or checkbox temporarily disabled when it is being clicked. The trick seems to stop IE from locking the mouse focus on the said widgets.

02/02/08 14:14:52 changed by fredck

  • keywords changed from Review? to Confirmed IE Review?.

02/02/08 17:04:05 changed by fredck

  • keywords changed from Confirmed IE Review? to Confirmed IE Review-.

02/02/08 17:04:17 changed by fredck

  • attachment 1782_2.patch added.

02/02/08 17:11:19 changed by fredck

  • keywords changed from Confirmed IE Review- to Confirmed IE Review?.

Martin, you are really good for finding those hacks. I've just changed your original patch a bit:

  • It does everything in fck_ie.js.
  • It simplified the logic a bit, as there is no need to do anything if the <input> element is already disabled.
  • I've reduced the timeout to re-enable the element to just 1ms. I noted a small flashing change with the original 50ms. 1ms seems to work, but if you have a precise motivation for 50ms, then feel free to revert it.
  • The function names have been generalized (for possible reuse) according to the names already in use. I'm not saying that I like "Doc_OnMouseDown", but that's the way we have the code now. We'll have our chance to change it in the future (V3).

If you fell it is ok, go ahead committing it.

02/04/08 05:33:56 changed by martinkou

  • keywords changed from Confirmed IE Review? to Confirmed IE Review+.

02/04/08 05:34:59 changed by martinkou

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed with [1467].

Click here for more info about our SVN system.