Ticket #1792 (closed Bug: fixed)

Opened 3 months ago

Last modified 2 months ago

[IE] Infinity loop problem in multiple editor

Reported by: lyg73 Assigned to: fredck
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version: SVN
Keywords: Confirmed IE Review+ Cc: mbuckallew

Description

Thank for FCKeditor team.
I using your product very usefully.
But I found a bug.
Please patch this bug... thank you

If change editor focus by mouse clicking then Internet Explorer fall into infinity loop in multiple editor page.
I create three editors in a page.
Click a first editor to edit html and switch to other window and click second editor then the editor fall into infinity loop.

The bug has in your sample page.
http://www.fckeditor.net/nightly/fckeditor/_samples/default.html[[BR]]

Change sample to FCKeditor - JavaScript - Sample 9 : Complex form(multiple editors)
Then two editors will be shown.
I will call EditorA (FCKeditor with Basic toolbar) and EditorB (FCKeditor with Default toolbar)

Steps to reproduce:
1. Click EditorA
2. Click the other window (except the fckeidtor browser)
3. Click EditorB
4. Then the Internet Explorer will be falled into infinity loop.


Browser name and OS
Internet Explorer 6 and 7
Windows XP sp2


Screenshot
No screenshot because bug is not editor content problem but infinity loop.

Sample data
Not need sample data...
This bug occur with any data..
I think that this bug is not related with a data...

Thank you.

Attachments

1792.patch (2.9 kB) - added by fredck on 03/21/08 17:08:58.

Change History

02/20/08 12:34:33 changed by w.olchawa

  • keywords set to Pending WorksForMe.
  • version set to SVN.

Hi!

I've tried to reproduce your bug but I was unsuccessful. Everything seems to work for me both in IE and IE7. So could you let me know what did you mean by 2. Click the other window (except the fckeidtor browser) because I interpreted it as clicking somewhere outside the editor, however I could misunderstood you.

Thanks!

03/05/08 13:14:46 changed by abakhar

Hi! I have the same bug reproduced with IE6 (6.0.2900.2180.xpsp_sp2_gdr.070227-2254) at WindowsXP SP2.
Steps to reproduce:
1. Run IE browser to open sample page with multiple editors as shown in the previous post.
2. Click first editor area to make it to get focus.
3. Click Start menu.
4. Click second editor area.
IE becomes unresponding. I think the bug caused by focus/blur routines.

03/05/08 21:47:06 changed by w.olchawa

  • keywords changed from Pending WorksForMe to Confirmed IE.
  • summary changed from Infinity loop problem in multiple editor to [IE] Infinity loop problem in multiple editor.

Confirmed using latest SVN version bot on IE6 and IE7.

03/13/08 10:20:29 changed by w.olchawa

#1988 has been marked as DUP

03/21/08 17:08:38 changed by fredck

  • cc set to mbuckallew.

03/21/08 17:08:58 changed by fredck

  • attachment 1792.patch added.

03/21/08 17:12:54 changed by fredck

  • keywords changed from Confirmed IE to Confirmed IE Review?.
  • owner set to fredck.
  • status changed from new to assigned.
  • milestone set to FCKeditor 2.6.

This is a regression for a bug I've worked on in the far 2006. As abakhar well understood, it is caused by the focus procedures, combined with the FCKFocusManager.

The problem is that the FCKFocusManager tries to enforce the focus to the editing area as soon as the editor window receives the focus. The code to do that fires the focus event again, and so FCKFocusManager starts the same procedure... in an infinite loop.

Our previous approach was blocking this issue in the focus procedure. But it seems that a safer solution is avoiding the loop at the FCKFocusManager code.

The attached patch, other than proposing the above approach, changes the FCKEditingArea.Focus code to make it clearer, canceling also a bug present on it currently, by a "return" statement wrong removed from line 275 with [620].

03/22/08 17:29:07 changed by alfonsoml

  • keywords changed from Confirmed IE Review? to Confirmed IE Review+.

My tests seems to work fine

03/22/08 17:40:58 changed by fredck

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed with [1775]. Click here for more info about our SVN system.