Ticket #1837 (closed Bug: fixed)

Opened 2 years ago

Last modified 18 months ago

Can not input <references /> - button missing

Reported by: chenxing Owned by:
Priority: Normal Milestone:
Component: Project : MediaWiki+FCKeditor Version: FCKeditor 2.6.3
Keywords: fixed Cc: cxcxcxcx@…, oradke@…

Description

Although there is a button to insert <ref>s, but there is no button to insert <references/> , I have to turn to "Wikitext" to add this tag. I guess it's a bug.

Attachments

1837.patch Download (1.9 KB) - added by arczi 19 months ago.
1837_2.patch Download (4.1 KB) - added by arczi 18 months ago.
1837_3.patch Download (2.2 KB) - added by arczi 18 months ago.
1837_4.patch Download (2.2 KB) - added by arczi 18 months ago.
1837_5.patch Download (4.2 KB) - added by arczi 18 months ago.
1837_6.patch Download (5.4 KB) - added by arczi 18 months ago.

Change History

Changed 2 years ago by w.olchawa

  • keywords Confirmed added

Changed 19 months ago by oradke

  • cc oradke@… added
  • version set to FCKeditor 2.6.3
  • summary changed from Can not input <references /> to Can not input <references /> - button missing

I saw that there's already code in the source and there's even an icon for the button. I hope it's easy to fix, since it is vital for the whole references concept to work.

Changed 19 months ago by arczi

  • keywords Review? added

Changed 19 months ago by arczi

Changed 19 months ago by wwalc

  • keywords Review- added; Review? removed

Actually we need two things:

  • as the original post says, we need a button that adds <references/> tag
  • ref and references buttons should be added automatically to the FCKeditor toolbar only when there is an extension that defines those two tags (Cite for example)

so this patch is simply invalid.

Changed 18 months ago by arczi

Changed 18 months ago by arczi

  • keywords Review? added; Review- removed

Changed 18 months ago by wwalc

  • keywords Review- added; Review? removed

Review-: there are syntax errors in fckplugin.js

Changed 18 months ago by arczi

Changed 18 months ago by arczi

  • keywords Review? added; Review- removed

Changed 18 months ago by arczi

Changed 18 months ago by wwalc

  • keywords Review- added; Review? removed

Looks fine, but: two files from 1837_2.patch are missing + when moving mouse over references button it is not highlighted. References tag is inserted correctly.

Changed 18 months ago by arczi

Changed 18 months ago by arczi

  • keywords Review? added; Review- removed

Changed 18 months ago by wwalc

  • keywords Review- added; Review? removed

When testing on MW13 / FF2 javascript errors occur.

Changed 18 months ago by arczi

Changed 18 months ago by arczi

  • keywords Review? added; Review- removed

Changed 18 months ago by wwalc

  • keywords Review+ added; Review? removed

Changed 18 months ago by arczi

  • keywords fixed added; Confirmed Review+ removed
  • status changed from new to closed
  • resolution set to fixed

Fixed with [2468]

Note: See TracTickets for help on using tickets.