Ticket #1997 (closed Bug: fixed)

Opened 2 months ago

Last modified 2 months ago

[IE] When you specify a title to a table, the first character is deleted

Reported by: estan Assigned to: fredck
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version: FCKeditor 2.6 Beta
Keywords: Confirmed IE Review+ Cc:

Description

Like the title suggests.

To reproduce, open the editor, click the button to add a table, fill for example the text 'hello' in the title field. click on OK, now you can see the table in the editor with on top the title in bold 'ello'

Attachments

1997.patch (5.3 kB) - added by fredck on 03/20/08 13:07:35.
1997_2.patch (5.3 kB) - added by fredck on 03/22/08 17:06:29.

Change History

03/11/08 17:49:40 changed by estan

I like to add that it only happens with IE(7) not with Firefox. You can even see the error in your demo http://www.fckeditor.net/demo

debugging with VS2008 gives me the problem in fckeditorcode_ie.js

After the ok click at the end of that function you have the following line: oEditor.FCK.InsertElement( table ) ; When i ask the quick watch of the table object, you can see clearly that the caption is correct. So, it must be happening when the object is converted to html code.

Good luck

03/12/08 12:36:12 changed by w.olchawa

  • keywords changed from table title to Confirmed IE.
  • summary changed from When you specify a title to a table, the first character is deleted to [IE] When you specify a title to a table, the first character is deleted.
  • milestone deleted.

Confirmed both in IE6 and IE7 using 2.6 beta and the latest SVN.

03/19/08 15:18:41 changed by fredck

  • owner changed.
  • component changed from UI : Dialogs to General.
  • milestone set to FCKeditor 2.6.

(Regression) This one is ok with version 2.5.1.

03/19/08 19:13:10 changed by fredck

It seems it has been introduced with [1404].

03/20/08 11:20:31 changed by fredck

  • owner set to fredck.
  • status changed from new to assigned.

03/20/08 13:07:35 changed by fredck

  • attachment 1997.patch added.

03/20/08 13:15:52 changed by fredck

  • keywords changed from Confirmed IE to Confirmed IE Review?.

The root of the problem was at FCKDomTools.MoveToElementEditStart. The logic there was not catching all cases.

I've completely rewritten that function in the patch, using now the DTD to identify the elements that can be editable. This solution is much straightforward.

I've also noted that the selection was not being placed in the right position on IE when creating forms or tables. I've done a small change on fckdialog.html. I would ask Martin to be sure that that change is ok, because I'm not sure why we have placed the Selection.EnsureSelection() call inside CloseDialog (which was making EnsureSelection be called two times for the Ok button).

03/22/08 13:47:24 changed by alfonsoml

  • keywords changed from Confirmed IE Review? to Confirmed IE Review-.

I would rename 

var editable ;

to 

var editableElement ;

There's a typo in fcklistslib.js // Elementst

and in the what's new: being properly handled when creating

03/22/08 17:06:29 changed by fredck

  • attachment 1997_2.patch added.

03/22/08 17:07:28 changed by fredck

  • keywords changed from Confirmed IE Review- to Confirmed IE Review?.

Good to hear that no critical things have been found in the patch. The new one fixes all your considerations.

03/26/08 04:52:37 changed by martinkou

  • keywords changed from Confirmed IE Review? to Confirmed IE Review+.

The bug was already fixed by [1795], so it cannot be reproduce with the newest SVN code anyways. The changes to MoveToElementEditStart() is still an sensible improvement to its robustness, however.

Moving the EnsureSelection() to inside Cancel() should be ok, I don't remember any particular reason I placed the EnsureSelection() inside CloseDialog(), and I wasn't able to discover any new bugs caused by the change anyway.

03/26/08 08:50:22 changed by fredck

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed with [1803]. Click here for more info about our SVN system.