Ticket #2142 (closed New Feature: fixed)

Opened 22 months ago

Last modified 21 months ago

HTML samples should use php extension in action paramter inside a form

Reported by: w.olchawa Owned by: w.olchawa
Priority: Normal Milestone: FCKeditor 2.6.1
Component: General Version: SVN (FCKeditor)
Keywords: Confirmed Review+ Cc:

Description

My suggestion is to replace sampleposteddata.asp with sampleposteddata.php in action parameter inside the form. I think that the usage of asp extension is less useful for the users. I don't know what is the most common used server side however I think that PHP is more popular than ASP (more of the users use Appache rather than IIS for example). Of course a user could always use the php examples however I don't see why php extension couldn't be used in html samples as well.

Attachments

2142.patch (12.2 KB) - added by w.olchawa 22 months ago.
2142_2.patch (12.6 KB) - added by w.olchawa 22 months ago.
Patch proposal

Change History

Changed 22 months ago by fredck

  • keywords Confirmed added; Discussion removed
  • milestone set to FCKeditor 2.6.1

It makes a lot of sense. PHP is definitely the most used language, related to the editor (we have done a research about it previously).

Changed 22 months ago by w.olchawa

  • owner set to w.olchawa

Changed 22 months ago by w.olchawa

I've attached a patch proposal. The patch should throw an error when trying to modify sampleposteddata.asp from _samples/html catalog. (because of attempt to delete it). However it shouldn't be a problem when committing the patch.

Changed 22 months ago by w.olchawa

Changed 22 months ago by w.olchawa

  • keywords Review? added

Changed 22 months ago by alfonsoml

  • keywords Review+ added; Review? removed

Please, update the what's new file remarking that it's an important change from previous versions.

Changed 22 months ago by w.olchawa

  • status changed from new to closed
  • resolution set to fixed

Fixes with [1947]

Changed 22 months ago by alfonsoml

  • status changed from closed to reopened
  • resolution fixed deleted

Now I think that instead of copying the sampleposteddata.php it would be better to change the action so it points to ../php/sampleposteddata.php

That way there's only one copy of that file and it's absolutely clear for anyone what to do if they are working with other languages.

Changed 22 months ago by w.olchawa

Good point I will provide a new patch in a few minutes

Changed 22 months ago by w.olchawa

  • keywords Review+ removed

Changed 22 months ago by w.olchawa

  • keywords Review? added

I don't see any reason for keeping sampleposteddata.html as well. I have applied changes to the patch.

Changed 22 months ago by w.olchawa

Patch proposal

Changed 22 months ago by alfonsoml

  • keywords Review+ added; Review? removed

Changed 21 months ago by w.olchawa

  • status changed from reopened to closed
  • resolution set to fixed

Fixed with [1957]

Note: See TracTickets for help on using tickets.