Ticket #2184 (closed Bug: fixed)

Opened 23 months ago

Last modified 23 months ago

Lots of html validation errors in the filemanager

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6.1
Component: File Browser Version: FCKeditor 2.6
Keywords: Review+ Cc:

Description

I don't know why we didn't realize earlier, but the filemanager has lots of validations errors that can be solved (most of them) easily.

Attachments

2184.patch Download (9.8 KB) - added by alfonsoml 23 months ago.
Proposed SVN patch

Change History

Changed 23 months ago by alfonsoml

Proposed SVN patch

Changed 23 months ago by alfonsoml

  • keywords Review? added

The patch fixes most of the problems, except some warnings about framespacing, bordercolor and frameborder but they might be trickier to do them properly as the behavior of styles in the framesets sometimes isn't able to fully reproduce the same effects.

So I suggest to fix the main issues and then if someone wants to play with the frames try it, but meanwhile the rest of issues have been fixed.

Changed 23 months ago by fredck

  • keywords Review+ added; Review? removed

I would just change the "table.fullHeight" selector to ".fullHeight", just to make it more useful... it could be used elsewhere if needed.

We can leave with the framesets warnings for now, until we work on a File Browser review.

Fell free to make or not that CSS change and commit it directly.

Changed 23 months ago by fredck

  • milestone set to FCKeditor 2.6.1

Changed 23 months ago by alfonsoml

  • status changed from new to closed
  • resolution set to fixed

Fixed with [1985]

Note: See TracTickets for help on using tickets.