Bad Spacing between two tables (FF2 Only)

[dshafik]

When you insert a table, click to the right side of it, and then add in a second table, it will display something like:

<table>...</table>

<table>...</table>

within the editor, but when you preview (or after saving) it shows up like:

<table>...</table>


<table>...</table>

The reason is that between the two tables, in the editor, there is a <p/> tag, which FF does not render. But when you preview/save, it is transformed into <p></p>.

You can see this in action at:  http://www.screencast.com/users/DShafik/folders/Jing/media/d4769677-866b-4a5b-8d21-1aa0a31cd14c

This issue affects 2.5.1 (at least) through to, and including trunk

[dshafik]

Table Spacing Patch

[fredck]

Confirmed with FF2. FF3 is ok.

Leave it targeted to the 2.6.2, to check the patch. Thanks dshafik!

[martinkou]

The patch works and makes sense. Good job. :)

I've made some simplifications to it and some coding style fixes, and added a comment to the code. Proposing a new patch for review.

[fredck]

The path is ok. It actually fixes FixBlock correctly, and should definitely land into the trunk.

But, other than the missing changelog entry (:P), one thing that bugs me out is: "Why the hell we have that <p/> there? Who said it should be there? After all, I want a table there!".

I'm working on a fix for all this, which will include the proposed patch.

[fredck]

This new patch includes the original proposed fix, but includes also another fix for the insertion of block elements. The following is the proposed behavior:

• If the selection is not inside a block (the source of the problem in this ticket), nothing in special is done. The new block is simply inserted at the current position. There is no need to SplitBlock (and therefore "FixBlock") first.

• If the selection is at the start of a block, the new block is simply insert "before" that block.

• If the selection is at the end of a block, the new block is then insert "after" that block.

• If the selection is at the middle of the block, the previous behavior is taken and the SplitBlock is called.

[fredck]

:| I always do that.

[fredck]

Fixed with [2106].