Ticket #2333 (closed Bug: fixed)

Opened 21 months ago

Last modified 19 months ago

'>' replace with '>' on safari and Opera

Reported by: tasyblue Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version: FCKeditor 2.5
Keywords: Review+ Cc:

Description

I found this bug on my google summer of code 2008 period. when I use fckeditor as moinmoin wiki's gui editor, sometimes document parser throw exception. When I insert '>' to editor area it change to '>' after FCKDataProcessor.ConvertToDataFormat executed. as I found, this behavior only happend on apple safari(3.1.1 on window xp. I couldn't test any other safari browser).

You can easily produce this bug using fckeditor's testcase.

  1. open _test/automated/tests/fckdataprocessor.html
  2. add new testcase end of testcases.
    function test_ConvertToDataFormat_Character_Transform()
    {
    	var dataProcessor = new FCKDataProcessor() ;
    
    	assertEquals(
    		'<p>&lt;&lt;GetText(Edit)&gt;&gt;</p>',
    		dataProcessor.ConvertToDataFormat( document.getElementById('xDiv3'), true, true ) ) ;
    }
    
  3. to test this testcase. add below html code inside of body tag
    <div id="xDiv3"><p>&lt;&lt;GetText(Edit)&gt;&gt;</p></div>
    
  4. then. run suite on safari.

attached file is testcase what I use and screeanshot of result.

  • Browser name and OS : Safari for window (3.1.1) and windows xp professional

Attachments

fckdataprocessor.html Download (6.1 KB) - added by tasyblue 21 months ago.
testcase file for produce same bug
bug_test_on_safari.jpg Download (120.6 KB) - added by tasyblue 21 months ago.
screenshot of jsunit test result
xml_gt.html Download (1.0 KB) - added by alfonsoml 20 months ago.
Simplified testcase
2333.patch Download (2.7 KB) - added by alfonsoml 20 months ago.
Proposed patch

Change History

Changed 21 months ago by tasyblue

testcase file for produce same bug

Changed 21 months ago by tasyblue

screenshot of jsunit test result

Changed 20 months ago by alfonsoml

  • version changed from SVN to FCKeditor 2.5
  • summary changed from '&gt;' replace with '>' on safari(3.1.1:windows) to '&gt;' replace with '>' on safari and Opera

Opera 9.51 also has the same behavior

This seems really a problem in their implementation of XMLSerializer, I'm attaching a simplified testcase that just creates an XML object with such a text node and then tries to serialize it.

Changed 20 months ago by alfonsoml

Simplified testcase

Changed 20 months ago by alfonsoml

Proposed patch

Changed 20 months ago by alfonsoml

  • keywords Review? added
  • owner set to alfonsoml
  • status changed from new to assigned

According to  http://www.w3.org/TR/REC-xml/#syntax that output it's correct, although we want all the browsers to have the same behavior, so the proposed patch does include the > in the list of special characters to handle.

I'm attaching also the automated testcase proposed by tasyblue

Changed 20 months ago by martinkou

  • milestone set to FCKeditor 2.6.4

The patch looks good to me. I think we can have this Review+ed and committed in 2.6.4.

Changed 20 months ago by martinkou

  • keywords Review+ added; Review? removed

Changed 19 months ago by alfonsoml

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [2359]

Note: See TracTickets for help on using tickets.