Support THEAD in Tables

[alfonsoml]

Take the patch of https://sourceforge.net/tracker/index.php?func=detail&aid=1409409&group_id=75348&atid=543655 review it and update to current version.

[alfonsoml]

Previous patch

[alfonsoml]

Updated patch

[alfonsoml]

I've updated the patch, fixing the issues that it had with IE and using some of the new FCKDomTools functions.

It's still missing the text entries in the language files and the corresponding what's new, but it should be enough to check that the code works as expected.

Does anyone have any suggestion or problem related to this patch?

[alfonsoml]

new patch

[alfonsoml]

I've modified the patch including the language files, and I've changed the UI, instead of using two checkboxes I think that it might be easier for the user to have a single select box with the available combination of headers.

I see that I've forgot about the what's new entry, it should be something like: New features: In the table dialog it's possible to create header cells in the first row (included in a thead element) or the first column of the table.

[martinkou]

The patch has a few problems that need to be fixed:

1. Create a default 2x3 table -> open table properties to set its first column to header -> open the table properties dialog again to set its first row to header. You'll see the top-left cell of the table remains a regular <td> cell. The culprit here is line 234 to line 242 in fck_table.html.
2. Line 196 should be th.scope = 'row' instead of th.scope = 'col', right?
3. The function FCKDomTools.RenameNode() is only used by fck_table.html so far. It seems to be more appropriate to define it inside fck_table.html to reduce core code size.
4. The changes to fckconfig.js shouldn't be in the patch.

[alfonsoml]

Revised patch

[alfonsoml]

1. I've changed the logic so it only changes cells inside the tbody element(s).
2. I think that line 196 was right, the problem was line 229, so that it matches the scopes generated if the headers are set at creation time.
3. The idea is to reuse the function for the cell dialog to switch between td and th, but I've moved to fck_dialog_common.js so it isn't in the core anymore.
4. Sorry, I didn't see it. I've attached the what's new changes this time.

[alfonsoml]

ups, now something it's failing in IE...

[alfonsoml]

new patch

[alfonsoml]

I've fixed a big problem in IE that placed the TH at the end of the row, and a little detail in Opera that sometimes it did include an extra empty <tbody>

[alfonsoml]

adjustement in the RenameNode function

[alfonsoml]

I've started looking at the TH option for the cell dialog and based on the previous patch by Martinkou I've remembered that now I can use the existing function to copy all attributes properly.

[alfonsoml]

Fixed with [2362]