Ticket #2603 (closed New Feature: fixed)

Opened 17 months ago

Last modified 15 months ago

Set EMailProtection to none by default.

Reported by: wwalc Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

Ok, I have noticed that this is a problem too late, but I guess we can still turn it off.

Reasons why I think it should be disabled:

  • it is not documented well (that can be fixed)
  • links are not usable if javascript is disabled (can't be fixed)
  • there are sites that filter posted content and strip code that looks like a potential XSS attack (via HTML Purifier for example), thus it doesn't work there even if javascript is enabled
  • it is a major change between last stable release and when upgrading from previous minor release most people expect no suprises

I think we have made a mistake by enabling it by default, but it may bee too late to change this. Anyway I'm posting this here for consideration.

Attachments

2603.patch Download (1.2 KB) - added by alfonsoml 17 months ago.
Proposed patch

Change History

Changed 17 months ago by wwalc

  • summary changed from Set EmailProtection set to none by default. to Set EMailProtection to none by default.

Changed 17 months ago by alfonsoml

In  http://dev.fckeditor.net/ticket/2488#comment:3 I already said that I think that the default should be no encryption, so I agree.

Changed 17 months ago by fredck

  • keywords Confirmed added; Discussion removed

Ok... let's disable it by default, as long as the editor is able to handle link previously encrypted.

Changed 17 months ago by alfonsoml

Proposed patch

Changed 17 months ago by alfonsoml

  • keywords Review? added
  • owner set to alfonsoml
  • status changed from new to assigned

Changed 15 months ago by fredck

  • keywords Review+ added; Review? removed

Changed 15 months ago by alfonsoml

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [2779]

Note: See TracTickets for help on using tickets.