Ticket #2616 (closed Bug: fixed)

Opened 17 months ago

Last modified 17 months ago

IE sometimes still insert at the beginning

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version:
Keywords: IE Review+ Cc:

Description

Despite the previous fixes for the 2.6.4 milestone, in the current SVN there are still some situations where IE can insert the new content at the beggining. One example is using the easyupload file dialog:  http://martinezdelizarrondo.com/easyupload

For the moment this is the best option that I've found:

  • fckdialog.html

     
    697697 
    698698                if ( frmMain.Ok && frmMain.Ok() ) 
    699699                        CloseDialog() ; 
    700                 else 
    701                         frmMain.focus() ; 
    702700        } ; 
    703701 
    704702        window.Cancel = function( dontFireChange ) 

Attachments

2616.patch Download (1.9 KB) - added by alfonsoml 17 months ago.
Proposed patch

Change History

Changed 17 months ago by alfonsoml

  • keywords IE Review? added; Discussion removed
  • owner set to alfonsoml
  • status changed from new to assigned

The problem is related to #2376, disabling the automatic save of selection also fixes the problem, so I've tested another approach that seems to work well: while a dialog is active, ignore any further automatic saving of the selection.

The fact is that debugging the calls to FCKSelection.Save, it can be seen that it's called three times whenever a dialog opens, and we just need one, any change of the selection while the dialog is open is an undesired one and should be ignored, so I added a variable to lock the stored selection.

Changed 17 months ago by alfonsoml

Proposed patch

Changed 17 months ago by fredck

  • keywords Review+ added; Review? removed

Changed 17 months ago by alfonsoml

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [2613]

Note: See TracTickets for help on using tickets.