Ticket #2696 (closed Bug: fixed)

Opened 16 months ago

Last modified 15 months ago

Fix autogrow in Firefox

Reported by: slessard Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version: FCKeditor 2.6.3
Keywords: Review+ Cc:

Description

Autogrow doesn't work in Firefox

Attachments

autogrow-firefox.patch Download (4.6 KB) - added by slessard 16 months ago.
Patch
2696.patch Download (4.3 KB) - added by martinkou 15 months ago.
2696_2.patch Download (5.2 KB) - added by martinkou 15 months ago.

Change History

Changed 16 months ago by slessard

Patch

Changed 16 months ago by slessard

Attached patch for the issue.

Changed 16 months ago by mosipov

  • keywords Review? added

Thanks for your contribution, I hope it will be quickly reviewed.

Changed 16 months ago by martinkou

  • owner set to martinkou
  • status changed from new to assigned

Changed 15 months ago by martinkou

  • milestone set to FCKeditor 2.6.4

Changed 15 months ago by martinkou

The proposed patch has some problems:

  1. The RemoveOverflow() function scrolls the editing area to the top in Firefox 3 whenever it is called, it must be removed.
  2. I'm not really sure what the "+ 16" in line 97 does... it gives me an editor frame that's 16px longer than needed in my tests. I guess the patch author needed some way of accounting for the body margin?

Proposing a new patch. It should work in IE, Firefox and Safari for Standards mode and Quirks mode documents. I haven't found a way to make it work in Opera due to browser bugs.

Changed 15 months ago by martinkou

Changed 15 months ago by fredck

  • keywords Review- added; Review? removed
  • The FCKAutoGrow variable declaration misses the "var" statement.
  • If you really want to put everything in an object, please use a literal object declaration (like var FCKAutoGrow = { MIN_HEIGHT : ..., Check : ..., ...} ;).
  • The changelog entry is missing.

Other than these details, the code looks good, and it works well. It should be read for Review+ after the above fixes.

Changed 15 months ago by martinkou

Changed 15 months ago by martinkou

  • keywords Review? added; Review- removed

Changed 15 months ago by fredck

  • keywords Review+ added; Review? removed

Changed 15 months ago by alfonsoml

#2350 did suggest another patch.

There might be more tickets about the same problem

Changed 15 months ago by martinkou

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [2793].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.