Ticket #2757 (closed Bug: fixed)

Opened 15 months ago

Last modified 14 months ago

Selection is not restored properly from bookmark2 in this case.

Reported by: jorenm@… Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version: FCKeditor 2.6.3 Beta
Keywords: Confirmed Review+ Cc:

Description

If you have a non-intrusive bookmark of a text selection that has a previous sibling that is not a text node FCK will not re-select it properly. The problem is that the bookmark creation code assumes the previous sibling will be a text node and it will break the bookmark if it is not.

These changes to the while loops fix it (fckdomrange.js line 477):

Old:

while ( curStart && addrStart.nodeType == 3 )
while ( curEnd && addrEnd.nodeType == 3 )

New:

while ( curStart && curStart.nodeType == 3 && addrStart.nodeType == 3 )
while ( curEnd && curEnd.nodeType == 3 && addrEnd.nodeType == 3 )

Attachments

2757.patch Download (0.9 KB) - added by arczi 14 months ago.

Change History

Changed 14 months ago by arczi

  • keywords Pending added

Could you provide a sample bookmark to reproduce this bug? Could you also check your editor version?

Changed 14 months ago by jorenm@…

1) Go to  http://www.fckeditor.net/demo

2) Select "are" after the bolded "sample text"

3) Hit bold

4) Hit undo

Changed 14 months ago by arczi

Changed 14 months ago by arczi

  • keywords Confirmed Review? added; Pending removed
  • version set to FCKeditor 2.6.3 Beta

Changed 14 months ago by martinkou

  • owner set to martinkou
  • status changed from new to assigned
  • milestone set to FCKeditor 2.6.4

Changed 14 months ago by martinkou

  • keywords Review+ added; Review? removed
  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [3026].

Note: See TracTickets for help on using tickets.