Ticket #4228 (closed New Feature: fixed)

Opened 7 months ago

Last modified 3 months ago

V3: Support for toolbar location "out" and toolbar sharing

Reported by: fredck Owned by: fredck
Priority: Normal Milestone: CKEditor 3.1
Component: UI : Toolbar Version:
Keywords: Confirmed Review+ Cc: mike@…

Description

Just like V2, it should be possible to set the toolbar location to somewhere outside the editor space, as well as share that same toolbar among several editor instances.

Attachments

4228.patch Download (34.9 KB) - added by garry.yao 5 months ago.
shared_spaces_iframe.patch Download (20.7 KB) - added by fredck 3 months ago.
Initial patch for the frames support.

Change History

Changed 5 months ago by n8behavior

  • cc mike@… added

we are migrating a customer of our to CKEditor and need this feature. i am going to be doing this quickly in our SVN/trac system. if you would like to view/use my changes you may do so here

 http://trac.lis.n8scm.net/ticket/10

Changed 5 months ago by garry.yao

Changed 5 months ago by garry.yao

  • keywords Review? added
  • owner set to garry.yao
  • status changed from new to assigned

Manual TCs added at :  http://ckeditor.t/tt/4228/1.html

Changed 5 months ago by n8behavior

awesome garry! can you tell me what version this patch was created against? also the link for TCs is broken. tx!

Changed 4 months ago by fredck

#4730 has been marked as DUP.

Changed 3 months ago by fredck

  • keywords Review- added; Review? removed
  • owner changed from garry.yao to fredck
  • status changed from assigned to new

Changed 3 months ago by fredck

  • keywords Review? added; Review- removed
  • status changed from new to assigned

I've created a branch in the SVN for this feature:
 http://svn.fckeditor.net/CKEditor/branches/features/sharedspaces/

The proposed approach is complete different now. The feature is not anymore called "toolbar out", but instead "shared spaces". This because with this new way we don't care what is really rendered in the top of toolbar. We may have a toolbar there, but can also have other things. For example, it's not possible to share also the elements path. A dedicated sample has been included to illustrate it.

There is a limitation though. It's not possible to share spaces in elements that are in other frames. This limitation is not really related to the approach we use in the branch, but it's caused by the way we handle skins and floating elements in V3.

We should go ahead with it in the way we have in the branch for now, which gives the necessary flexibility related to this feature. We can then listen for feedback from our community after the release to understand whether the frames support is really needed and then investigate solutions for it.

Changed 3 months ago by garry.yao

  • keywords Review- added; Review? removed

Two issues found: 1. Please populate the changes to other skins as well; 2. The following css rules change has broken the toolbar collapser ( by rendering the toolbox as invisible ):  http://dev.fckeditor.net/changeset/4644/CKEditor/branches/features#file6

Changed 3 months ago by fredck

  • keywords Review? added; Review- removed

Both issues fixed in the feature branch.

Changed 3 months ago by garry.yao

  • keywords Review+ added; Review? removed

Changed 3 months ago by fredck

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [4653].

Changed 3 months ago by fredck

Initial patch for the frames support.

Changed 3 months ago by fredck

I'm attaching here, for reference, an initial patch to bring frames support for this feature. It's not perfect though, and may break things in specific situations (e.g. when creating a simple editor instance inside an iframe and opening a dialog).

Note: See TracTickets for help on using tickets.