Ticket #4340 (closed New Feature: fixed)

Opened 7 months ago

Last modified 3 months ago

Implement Email protection

Reported by: alfonsoml Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: Core : Output Data Version: SVN (CKEditor)
Keywords: Confirmed Review+ Cc:

Description

Port #2220 to CKEditor (or something better if it's even possible :) )

Attachments

4340.patch Download (7.5 KB) - added by garry.yao 5 months ago.
4340_2.patch Download (8.6 KB) - added by garry.yao 4 months ago.
4340_3.patch Download (9.9 KB) - added by garry.yao 4 months ago.
4340_4.patch Download (9.9 KB) - added by garry.yao 3 months ago.

Change History

Changed 5 months ago by garry.yao

Changed 5 months ago by garry.yao

  • keywords Confirmed Review? added
  • owner set to garry.yao
  • status changed from new to assigned
  • component changed from General to Core : Output Data
  • version changed from 3.0 to SVN (CKEditor)

Changed 5 months ago by garry.yao

Changed 4 months ago by fredck

  • keywords Review- added; Review? removed

Having it implemented as filters definitely have its benefits, like automatic protection even when the user is not aware about. But, the drawback is that all the code goes into the core.

We must keep an eye in the file size also, so I would propose having this as a dialog feature, much like V2. If we understand that having this enabled as a filter is critical we'll then re-implement it later. We must consider the contents products with the editor for now.

Changed 4 months ago by garry.yao

Changed 4 months ago by garry.yao

  • keywords Review? added; Review- removed

Now the protection only affect dialog operation.
Ticket Test updated.

Changed 4 months ago by fredck

  • keywords Review- added; Review? removed
  • This quite back TC is broken after the patch:
  1. With default config, load this HTML:
<p><a href="http://www.example.com">Test</a></p>
  1. Right click into "Test" and open the link properties dialog.

The href value will not be loaded.


  • The config should be named emailProtection, not mailProtection.
  • The config documentation is wrong. The @name tag cannot be the first thing there. The very first thing must be the description. I think jsdoc will not work otherwise.
  • Again in the documentation, the type is "String", but the default value is "false" (???). I think you wanted to say empty string there.
  • And finally, there is no ASC2... but ASCII :).
  • I have used the following setting:
config.mailProtection = 'abcd(NAME,SUBJECT,BODY,DOMAIN)';

... having these results by filling the e-mail address only with "test@…":

<p><a href="javascript:abcd('test','example.com')">Test</a></p>

... expected:

<p><a href="javascript:abcd('test','','','example.com')">Test</a></p>

Changed 4 months ago by garry.yao

  • keywords Review? added; Review- removed

Changed 4 months ago by garry.yao

Changed 3 months ago by fredck

  • keywords Review- added; Review? removed

We're almost there. I've just found one (quite hidden) issue:

  1. Load the following HTML:
<p><a name="Target"></a>This is a <a href="#Target">sample</a>.</p>
  1. Right-click the "sample" link and open the link dialog to edit it.

The dialog doesn't load the Anchor properly. The "Link Type" field should be "Link to anchor in the text".

Changed 3 months ago by garry.yao

Changed 3 months ago by garry.yao

  • keywords Review? added; Review- removed

Changed 3 months ago by fredck

  • keywords Review+ added; Review? removed

Changed 3 months ago by garry.yao

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [4608] at 3.1.x branch.

Note: See TracTickets for help on using tickets.