Ticket #4455 (closed Bug: fixed)

Opened 6 months ago

Last modified 2 months ago

Unable to start editing when image inside document not loaded

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: SVN (CKEditor)
Keywords: Confirmed Review+ Cc: diego@…

Description

If there's large image inside the editing document, the wysiwyg mode will be totally freezed while the image is loading.
Not sure if we could try to initialize the editing document a little bit earlier than 'onload', namely the 'onDomReady' technique.

Attachments

4455.patch Download (2.0 KB) - added by garry.yao 4 months ago.
4455_2.patch Download (1.1 KB) - added by garry.yao 4 months ago.

Change History

Changed 6 months ago by garry.yao

Ticket Test added at :  http://ckeditor.t/tt/4455/1.html.

Changed 5 months ago by garry.yao

  • version set to SVN (CKEditor)
  • milestone CKEditor 3.1 deleted

Changed 5 months ago by fredck

  • milestone set to CKEditor 3.1

Let's investigate it. It's an important issue.

Changed 4 months ago by garry.yao

Changed 4 months ago by garry.yao

  • keywords Confirmed Review? added
  • owner set to garry.yao
  • status changed from new to assigned

The patch include the patch of dependent ticket #3598.

Changed 4 months ago by fredck

  • keywords Review- added; Review? removed

I think you were talking about #3593 instead. The comments there make this patch not useful anymore.

Please do not mix the patches. You may indicated that a patch form other ticket must be also applied, or even point that we need to fix another ticket first.

Now, considering that the activationScript is appended to the document after the closing <html>, is the onload event really needed? Can't we call the "temporary function" directly?

Changed 4 months ago by garry.yao

Changed 4 months ago by garry.yao

  • keywords Review? added; Review- removed

Ticket Manual Test added at :
 http://ckeditor.t/tt/4455/1.html.

Changed 4 months ago by fredck

  • keywords Review+ added; Review? removed

Changed 4 months ago by garry.yao

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [4541].

Changed 2 months ago by dcaravana

  • cc diego@… added
  • status changed from closed to reopened
  • resolution fixed deleted

Sometimes the following code is appended to the content of the editor: 

<script id="cke_actscrpt" type="text/javascript">window.​parent.​CKEDITOR._["con­tentDomReadyeditor"]( window );</script>

In my case, I save the content to the database to be used in a different context than a browser so the script tag creates a problem; in any case it should not be part of the real (user) content.

Changed 2 months ago by garry.yao

  • status changed from reopened to closed
  • resolution set to fixed

Please don't reopen fixed ticket unless you're sure it's the regression that brought by the fixing, open new ticket instead.

Note: See TracTickets for help on using tickets.