Ticket #4514 (closed Bug: fixed)

Opened 5 months ago

Last modified 4 months ago

Editor edit area disables on back button

Reported by: bohnman Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: 3.0
Keywords: Firefox Confirmed Review+ Cc:

Description

Environment - Firefox 3.5.3 on Mac OSX Leopard

This is reproducible in the samples, specifically replacebyclass.html

- open up the sample html in FireFox - now go to another site like google - then, click back button so your back on the sample - you are now unable to click in the edit area until you toggle view source

Attachments

4514.patch Download (0.9 KB) - added by garry.yao 4 months ago.
4514_2.patch Download (1.0 KB) - added by garry.yao 4 months ago.

Change History

Changed 4 months ago by garry.yao

  • keywords Firefox added
  • status changed from new to closed
  • resolution set to wontfix

Known limitation of contentEditable in Firefox.

Changed 4 months ago by garry.yao

  • keywords Confirmed added
  • status changed from closed to reopened
  • resolution wontfix deleted
  • milestone set to CKEditor 3.1

After some investigation, the FF bug behind this was reported  here and it was lucky to find out a solution for both this bug and #3907.

Changed 4 months ago by garry.yao

  • keywords Review? added

Changed 4 months ago by garry.yao

Changed 4 months ago by fredck

  • owner set to garry.yao
  • status changed from reopened to new

Changed 4 months ago by fredck

  • keywords Review- added; Review? removed

The patch is ok. I would just investigate other ways to apply onpageshow:

  1. In the proposed way, onpageshow could be in conflict with other code using it in the page. We must check if it's possible to set it as a normal event.
  1. We could try adding the onpageshow attribute in the content area instead. We may also try setting it directly to the <body> tag when creating the string we load in the editing area.

If none of the above are good for it, the provided patch would be ok.

Changed 4 months ago by garry.yao

Changed 4 months ago by garry.yao

  • keywords Review? added; Review- removed
  • status changed from new to assigned

It's much more safe to preserve the original attribute now.

We could try adding the onpageshow attribute in the content area instead.

It's not working since the whole editing frame is cached too.

Changed 4 months ago by fredck

  • keywords Review+ added; Review? removed
  • You have reported a  Mozilla bug for this issue, but it's not clear it's related to the same thing. Please be sure we have a bug for it there, making a reference to it here.
  • Be sure to close #3907 when closing this one.

Changed 4 months ago by garry.yao

  • status changed from assigned to closed
  • resolution set to fixed

A more accurate bug report is delivered to Mozilla.
 https://bugzilla.mozilla.org/show_bug.cgi?id=529321 Fixed with [4492].

Note: See TracTickets for help on using tickets.