Ticket #4594 (closed Bug: fixed)

Opened 5 months ago

Last modified 3 months ago

Context menu goes off-screen when mouse is at right had side of screen.

Reported by: JoeK Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: 3.0.1
Keywords: IBM Confirmed Review+ Cc: damian.chojna@…, pomu@…

Description

Create an editor instance that spans the with of the screen. Move the mouse to the right hand side of the editor and right click. Observe the context menu is partially rendered off screen. See attached screen shot. The context menu should be rendered to the left of the mouse.

Scroll bars are rendered so it can be accessed if the user moves to the right.

Attachments

CKEditor Context Menu.bmp Download (0.8 MB) - added by JoeK 5 months ago.
Off-screen context menu screen shot
4594.patch Download (0.5 KB) - added by pomu0325 5 months ago.
4594_2.patch Download (4.7 KB) - added by garry.yao 5 months ago.
4594_3.patch Download (2.5 KB) - added by garry.yao 5 months ago.
4594_4.patch Download (2.6 KB) - added by garry.yao 4 months ago.
4594_5.patch Download (4.0 KB) - added by garry.yao 4 months ago.
4594_6.patch Download (3.0 KB) - added by garry.yao 3 months ago.
SubmenuOverlap.gif Download (7.5 KB) - added by damo 3 months ago.

Change History

Changed 5 months ago by JoeK

Off-screen context menu screen shot

Changed 5 months ago by pomu0325

Changed 5 months ago by pomu0325

  • cc pomu@… added

I faced the same problem and I did a workaround with this patch. Tested with IE8, FF3 and Chrome, only in 'ltr' situation.

Changed 5 months ago by garry.yao

  • keywords Confirmed HasPatch added

Changed 5 months ago by garry.yao

Changed 5 months ago by garry.yao

  • keywords Review? added; HasPatch removed
  • owner set to garry.yao
  • status changed from new to assigned

Implement full off-screen support for context menu inspired by pomu's patch.

Changed 5 months ago by garry.yao

Changed 5 months ago by garry.yao

As discussed with Fred, we may even come out a "just work" solution which cascade float panels for off-screen, which is more implementation lightweight than the previous patch. Ticket Test added at :
 http://ckeditor.t/tt/4594/1.html.

Changed 4 months ago by fredck

  • keywords Review- added; Review? removed

It looks like page scrolling impacts on the calculations. In both IE and FF, the panel opens to the top if you scroll down the page and opens the context menu, even if there is room for it at the bottom of the cursor.

Changed 4 months ago by garry.yao

Changed 4 months ago by garry.yao

  • keywords Review? added; Review- removed

Nice catch indeed.

Changed 4 months ago by fredck

  • keywords Review- added; Review? removed

After patching, in FF:

  1. Load a sample.
  2. Click the color selector.
  3. With the color selector opened, click any of the combos.

The color selector remains opened. It happens only on first opening, with all combinations of panels opening order, including the context menu.

In IE instead, the panels don't show on first click.

Changed 4 months ago by garry.yao

Changed 4 months ago by garry.yao

  • keywords Review? added; Review- removed

The activation function is been placed at wrong place in previous patch.

Changed 4 months ago by fredck

  • keywords Review- added; Review? removed

No change in IE. The panels are still not showing on first click.

Changed 4 months ago by garry.yao

  • keywords Review? added; Review- removed

Changed 4 months ago by fredck

  • keywords Review- added; Review? removed

I confirm that in IE8 the panels don't appear on first click.

Changed 3 months ago by garry.yao

Changed 3 months ago by garry.yao

  • keywords Review? added; Review- removed

Changed 3 months ago by fredck

  • keywords Review+ added; Review? removed

Changed 3 months ago by garry.yao

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [4606].

Changed 3 months ago by damo

  • status changed from closed to reopened
  • resolution fixed deleted

This solution partially fixes the problem. The sub menu displays over the main menu, making it impossible to navigate around the context menu properly. The sub menu should really display to the side of the main menu.

See attached screenshot: SubmenuOverlap.gif

Changed 3 months ago by damo

Changed 3 months ago by garry.yao

  • status changed from reopened to closed
  • resolution set to fixed

The sub menu displays over the main menu...

Please refer to  previous comment as our decision for it, feel free to open a new ticket for the feature you're suggesting though.

Note: See TracTickets for help on using tickets.