Ticket #4690 (closed Bug: fixed)

Opened 4 months ago

Last modified 3 months ago

htmlParser goes wrong with empty inline elements

Reported by: garry.yao Owned by: fredck
Priority: Normal Milestone: CKEditor 3.1
Component: Core : Output Data Version: SVN (CKEditor)
Keywords: Confirmed Review+ Cc:

Description

Having htmlParser deal with the following input:

<span><span></span>text</span>

With incorrectly yield:

text

Attachments

4690.patch Download (0.7 KB) - added by garry.yao 4 months ago.
4690_2.patch Download (1.7 KB) - added by garry.yao 4 months ago.
4690_3.patch Download (2.0 KB) - added by fredck 4 months ago.

Change History

Changed 4 months ago by garry.yao

Changed 4 months ago by garry.yao

  • keywords Confirmed Review? added
  • owner set to garry.yao
  • version set to SVN (CKEditor)
  • status changed from new to assigned
  • milestone set to CKEditor 3.1

Changed 4 months ago by garry.yao

Ticket Test added at :
 http://ckeditor.t/tt/4690/1.html.

Changed 4 months ago by fredck

  • keywords Review+ added; Review? removed

Definitely makes sense. You may fix the comment to "a pending tag".

Changed 4 months ago by garry.yao

  • keywords Review- added; Review+ removed

R- for failing the following TC:

assert.areSame( '<span class="outer">text</span>', htmlParse( '<span class="outer"><span></span>text</span>' ) );

Changed 4 months ago by garry.yao

Changed 4 months ago by garry.yao

  • keywords Review? added; Review- removed

Previous patch was closing the pending element in wrong direction.

Changed 4 months ago by fredck

  • keywords Review- added; Review? removed
  • owner changed from garry.yao to fredck
  • status changed from assigned to new

I've just found out that the code just needs to be simplified to make it work. I'll come with a new patch for it.

Changed 4 months ago by fredck

Changed 4 months ago by fredck

  • keywords Review? added; Review- removed
  • status changed from new to assigned

The pending list must be the first thing to get checked when closing a tag.

Changed 3 months ago by garry.yao

  • keywords Review+ added; Review? removed

That's a perfect fix, plz mark the ticket TC as stable after fixed.

Changed 3 months ago by fredck

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [4622].

Note: See TracTickets for help on using tickets.