Ticket #4822 (closed Bug: fixed)

Opened 3 months ago

Last modified 3 months ago

[IE] Applying 'Headers' to existing table does not work

Reported by: pomu0325 Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: UI : Dialogs Version: SVN (CKEditor)
Keywords: Confirmed Review+ Cc: pomu@…

Description

To Reproduce

  • Open CKEditor sample
  • Click 'table' button from toolbar
  • Just click OK to add a new table
  • Right click inside of first cell and select table properties
  • Change 'Headers' from 'None' to 'First Row'
  • Click OK
  • Then, 'invalid argument' error occurs at l.982 of selection/plugin.js, and whole content is removed from editor!

Attachments

4822.patch (0.8 KB) - added by garry.yao 3 months ago.

Change History

Changed 3 months ago by garry.yao

  • keywords Confirmed Review? added
  • owner set to garry.yao
  • status changed from new to assigned
  • component changed from General to UI : Dialogs
  • milestone set to CKEditor 3.1

Since certain operation from the table properties dialog modifies the table structure, we should have the original selection well-protected.

Changed 3 months ago by garry.yao

Changed 3 months ago by pomu0325

  • keywords Review+ added; Review? removed

It worked, thanks for quick fix.

Changed 3 months ago by fredck

  • keywords Review? added; Review+ removed

@pomu0325, the review processes is to be performed by the core development team. Thanks anyway for you effort, as the patch is definitely good.

Changed 3 months ago by fredck

  • keywords Review+ added; Review? removed

Changed 3 months ago by garry.yao

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with [4786].

Note: See TracTickets for help on using tickets.