Opened 14 years ago

Closed 14 years ago

#5902 closed Bug (fixed)

paste and pastetext dialogs can not be skinned easily.

Reported by: Joe Kavanagh Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.4
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Review+ Cc: Damian Satya Minnekanti

Description

The paste and pastetext dialogs are built using HTML UI elements. The HTML contains hard-coded style attribute values, as the following code from the pastetext dialog shows:

{
type : 'html',
id : 'content',
style : 'width:340px;height:170px',
html :
	'<textarea style="' +
		'width:346px;' +
		'height:170px;' +
		'resize: none;' +
		'direction:' + editor.config.contentsLangDirection + ';' +
		'border:1px solid black;' +
		'background-color:white">' +
	'</textarea>',

As with the image and flash dialogs, can the tags in the HTML content be given an id attribute, and the style moved out to the skin's dialog.css. Only dynamic styles should remain.

Attachments (2)

5902.patch (3.4 KB) - added by Tobiasz Cudnik 14 years ago.
5902_2.patch (4.1 KB) - added by Tobiasz Cudnik 14 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 14 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added

comment:2 Changed 14 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

comment:3 Changed 14 years ago by Tobiasz Cudnik

Keywords: Review? added

Changed 14 years ago by Tobiasz Cudnik

Attachment: 5902.patch added

comment:4 Changed 14 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review- added; Review? removed

Maybe we should use a dialog.ui.textarea element instead of using a Html element with the textarea as the content?

And so, the basic style of border and background-color should be available for all the dialog.ui.textarea elements

Changed 14 years ago by Tobiasz Cudnik

Attachment: 5902_2.patch added

comment:5 Changed 14 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

This kind of inheritance is a good idea, fixed that in new patch.

comment:6 Changed 14 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 14 years ago by Tobiasz Cudnik

Fixed with [5705].

comment:8 Changed 14 years ago by Tobiasz Cudnik

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy