Ticket #738 (closed Bug: fixed)

Opened 11 months ago

Last modified 3 months ago

Cannot change the button type after creating it

Reported by: aaronvg@users.sourceforge.net Assigned to: martinkou
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version: FCKeditor 2.5.1
Keywords: Confirmed IE Review- Cc:

Description

Once inserted, one cannot change the button type of a button in a form anymore.

Steps: 

- Insert form
- Insert button (type = button)
- Open contextmenu of button
- Type field is disabled.

Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1501651&group_id=75348&atid=543653

Attachments

738.patch (1.9 kB) - added by martinkou on 02/05/08 06:01:18.

Change History

06/25/07 06:31:03 changed by martinkou

  • reporter changed from martinkou to aaronvg@users.sourceforge.net.

01/30/08 14:21:27 changed by w.olchawa

  • keywords changed from SF to SF Confirmed IE IE7.
  • version set to FCKeditor 2.5.1.
  • summary changed from Cannot change the button type of a button to Cannot change the button type after creating it.

Confirmed on IE and IE7. In FF the problem is bigger because you can't access the button properties. See #703.

01/31/08 16:35:19 changed by w.olchawa

  • keywords changed from SF Confirmed IE IE7 to SF Confirmed IE.

02/04/08 17:38:33 changed by martinkou

  • owner set to martinkou.
  • status changed from new to assigned.

02/05/08 06:00:54 changed by martinkou

Targeting to 2.6 since it is related to dialogs.

02/05/08 06:01:18 changed by martinkou

  • attachment 738.patch added.

02/05/08 06:01:33 changed by martinkou

  • keywords changed from SF Confirmed IE to SF Confirmed IE Review?.
  • milestone set to FCKeditor 2.6.

02/06/08 23:15:44 changed by alfonsoml

  • keywords changed from SF Confirmed IE Review? to Confirmed IE Review-.

That code would lose any other property that isn't handled by this dialog (like class, style or any event handler). It might not be common, but it is a possibility. So I Review- because that's data loss.

In #676 I added the code to handle also this issue, but there are some ideas (like not creating a new element if the special properties haven't changed) in this patch that I must apply.

02/11/08 19:15:27 changed by alfonsoml

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in #676