Ticket #738 (closed Bug: fixed)

Opened 3 years ago

Last modified 2 years ago

Cannot change the button type after creating it

Reported by: aaronvg@… Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version: FCKeditor 2.5.1
Keywords: Confirmed IE Review- Cc:

Description

Once inserted, one cannot change the button type of a button in a form anymore.

Steps:

- Insert form
- Insert button (type = button)
- Open contextmenu of button
- Type field is disabled.

Moved from SF:
 http://sourceforge.net/tracker/index.php?func=detail&aid=1501651&group_id=75348&atid=543653

Attachments

738.patch Download (1.9 KB) - added by martinkou 2 years ago.

Change History

Changed 3 years ago by martinkou

  • reporter changed from martinkou to aaronvg@…

Changed 2 years ago by w.olchawa

  • keywords Confirmed IE IE7 added
  • version set to FCKeditor 2.5.1
  • summary changed from Cannot change the button type of a button to Cannot change the button type after creating it

Confirmed on IE and IE7. In FF the problem is bigger because you can't access the button properties. See #703.

Changed 2 years ago by w.olchawa

  • keywords IE7 removed

Changed 2 years ago by martinkou

  • owner set to martinkou
  • status changed from new to assigned

Changed 2 years ago by martinkou

Targeting to 2.6 since it is related to dialogs.

Changed 2 years ago by martinkou

Changed 2 years ago by martinkou

  • keywords Review? added
  • milestone set to FCKeditor 2.6

Changed 2 years ago by alfonsoml

  • keywords Review- added; SF Review? removed

That code would lose any other property that isn't handled by this dialog (like class, style or any event handler). It might not be common, but it is a possibility. So I Review- because that's data loss.

In #676 I added the code to handle also this issue, but there are some ideas (like not creating a new element if the special properties haven't changed) in this patch that I must apply.

Changed 2 years ago by alfonsoml

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in #676

Note: See TracTickets for help on using tickets.