Ticket #1691: 1691_2.patch

_whatsnew.html

@@ -81 +81 @@
                         correctly restored when undoing changes made by the Replace dialog.</li>
                 <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/2160">#2160</a>] "Match whole word" in the
                         Find and Replace dialog will now find words next to punctuation marks as well.</li>
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/1691">#1691</a>] Creation of links in Safari
+                        failed if there was no selection.</li>
         </ul>
         <h3>
                 Version 2.6</h3>

editor/_source/internals/fck_gecko.js

@@ -415 +415 @@
         // Creates the array that will be returned. It contains one or more created links (see #220).
         var aCreatedLinks = new Array() ;
 
+        // Only for Safari, a collapsed selection may create a link. All other
+        // browser will have no links creates. So, we check it here and return
+        // immediatelly, having the same cross browser behavior.
+        if ( FCKSelection.GetSelection().isCollapsed )
+                return aCreatedLinks ;
+
         FCK.ExecuteNamedCommand( 'Unlink', null, false, !!noUndo ) ;
 
         if ( url.length > 0 )
@@ -434 +440 @@
                         var oLink = oLinksInteractor.snapshotItem( i ) ;
                         oLink.href = url ;
 
-                        // It may happen that the browser (aka Safari) decides to use the
-                        // URL as the link content to not leave it empty. In this case,
-                        // let's reset it.
-                        if ( sTempUrl == oLink.innerHTML )
-                                oLink.innerHTML = '' ;
-
                         aCreatedLinks.push( oLink ) ;
                 }
         }