Opened 11 years ago
Closed 11 years ago
#10166 closed Bug (fixed)
Full page sample - image alignment is lost
| Reported by: | Wiktor Walc | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.1 |
| Component: | General | Version: | 4.1 RC |
| Keywords: | Cc: |
Description
align="right"
in the first image at the top is removed
Change History (9)
comment:1 Changed 11 years ago by
| Status: | new → confirmed |
|---|
comment:3 Changed 11 years ago by
| Milestone: | → CKEditor 4.1 |
|---|
comment:4 Changed 11 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | confirmed → assigned |
comment:6 Changed 11 years ago by
| Status: | review → review_failed |
|---|
Failing tests:
IE7|8:
- test-alignleft-attribute-transformation:
Expected: /<p><img data-cke-saved-src="http:\/\/test\/x" src="http:\/\/test\/x" style="float: ?left;?" \/><\/p>/ Actual: <p><img data-cke-saved-src="http://test/x" src="http://test/x" style="FLOAT: left" /></p>
FF latest:
- test-alignment-transformations:
Expected: <h2 align="middle">A</h2> Actual: <h2 align="center">A</h2>
Also I guess that this line introduced by this commit can now be reverted.
comment:7 Changed 11 years ago by
| Status: | review_failed → review |
|---|
I fixed broken tests.
This commit was about switching off ACF in full page sample because in full page usually user need full control over the document.
comment:8 Changed 11 years ago by
| Status: | review → review_passed |
|---|
comment:9 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed on major with git:528fc75 on dev and 247a483 on tests.
Note: See
TracTickets for help on using
tickets.
This happens because align="right" is not allowed by image plugin. Image plugin uses float rather than align attribute, so this sample is incorrect.
Additionally, transformation group should be added.