ACF should not clean up non-empty link without href attribute

[Piotrek Koszuliński]

Source: ​http://ckeditor.com/comment/124493#comment-124493

I think that I got a little bit too far when implementing #10073. Non-empty link without href attribute is valid (in HTML5) and should not be stripped when allowed by ACF. Links (not including anchors - <a> elements with name and without href) should only be stripped when they are empty.

[Piotrek Koszuliński]

Pushed ​t/10224 on dev and tests.

• In validateElement I decided to use the same code which htmlDP uses. Thanks to that it will be backward compatible.
• I had to add clean up for data-cke-saved-* attributes, because after stripping href, data-cke-saved-href was left, so href was recreated after getting data.

[Olek Nowodziński]

Review passed. But non-trivial things like this in tests need additional explanation:

filter( '<p>X<a href="x" name=""></a>X</p>',     '<p>XX</p>' );

vs.

filter( '<p>X<a name="">A</a>X</p>',             '<p>X<a name="">A</a>X</p>' );

Otherwise we'll get lost soon.

[Piotrek Koszuliński]

Fixed on major with ​git:0948a5b on dev and b54618f on tests.

I pushed special comments explaining not obvious cases.

[Bert Hankes]

Hi,

Just installed 4.1 and still the same problem :-(

I have (exerpt):

var allowed = 'a(iLink)[!title,!onclick,href]', required = 'a(iLink)[title,onclick]';

editor.addCommand( 'internelink', new CKEDITOR.dialogCommand( 'internelinkDialog' ),{allowedContent: allowed, requiredContent: required } );

It produces the following tag: <p><a class="iLink" onclick="iLink(25)" title="test">test</a></p>

But when changing to source and back all left is: <p>test</p>

I could be wrong in programming the plugin, but I use the link-example as reference!

[Piotrek Koszuliński]

I made a sample 10224.html​ that proves that ACF, if configured correctly, does not remove this link.

I think that the problem is somewhere else. You add a command, but you do not activate the feature. A feature is activated automatically only when it is a button added to toolbar (I don't see a button in that excerpt). In other cases you need to call editor.addFeature() manually. In your case it will be:

var cmd = editor.addCommand( 'interlink', ... );
editor.addFeature( cmd );

Check the "A button, command or maybe a plugin – which of them is a feature?" chapter in this guide: ​http://docs.ckeditor.com/#!/guide/plugin_sdk_integration_with_acf

[Bert Hankes]

Hi Reinmar,

You made my day! Briljant.. it works!!!! Keep this ticket closed and you have earned a beer!

[Piotrek Koszuliński]

Hehe :) I'm glad I could help. And that this isn't an editor bug ;).