Opened 11 years ago

Closed 11 years ago

#10831 closed Bug (fixed)

Image2: Merge inline and block widget, fix allowed|requiredContent

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Must have (possibly next milestone) Milestone: CKEditor 4.3
Component: General Version: 4.3 Beta
Keywords: Cc:

Description

As mentioned in the comment ​http://dev.ckeditor.com/ticket/10659#comment:15

Change History (6)

comment:1 Changed 11 years ago by Piotrek Koszuliński

Priority: Normal → High
Status: new → confirmed

comment:2 Changed 11 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmed → assigned

comment:3 Changed 11 years ago by Olek Nowodziński

Status: assigned → review

Created branches in dev ​t/10831 and tests. Changes:

  • Widgets image2block and image2inline got merged and became image2.
  • Aligned image2 tests to the above change.
  • Added missing tests for justify plugin integration.
  • Fixed an issue: when switching from inline widget to block (and vice-versa) i.e. when adding/removing caption, the focused widget loses focus as it's destroyed and a new instance is created (+tests).
  • Minor code re-factoring.

comment:4 Changed 11 years ago by Piotrek Koszuliński

Pushed few commits with simplifications and small improvements. I will continue review tomorrow.

comment:5 Changed 11 years ago by Piotrek Koszuliński

Status: review → review_passed

Manual and automated tests went very well.

comment:6 Changed 11 years ago by Olek Nowodziński

Resolution: → fixed
Status: review_passed → closed

Merged changes into major, dev (​​git:6842248), tests (390dd0f).

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy